Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapp-feat: Export Transaction to CSV feature complete (#421) #424

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

quiet-node
Copy link
Member

Description:

  • revised the logic for deleting transactions in the main activity page. Prior to this update, users had the option to click on individual delete buttons next to each transaction to remove a specific transaction, or they could delete all transactions at once by clicking on the 'Remove all transactions' button. Now, individual delete buttons are replaced with checkboxes, enabling users to select multiple transactions at once and perform desired actions on them. Additionally, the 'Remove all transactions' button is replaced with 'Remove selected transactions,' allowing users to delete transactions that have their checkboxes checked.

  • finished the new exporting transactions to CSV feature. Users now have the ability to select the transactions they want to export. The new exported CSV file will be under the name hedera-system-contract-dapp-transactions.csv by default.

Related issue(s): #399

Fixes #421

** UI Demo & Explanation **:
https://www.loom.com/share/0761b60be7974984877d17027c7558cc

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added enhancement New feature or request P2 Tooling tooling labels Oct 3, 2023
@quiet-node quiet-node added this to the 0.6.0 milestone Oct 3, 2023
@quiet-node quiet-node requested a review from a team as a code owner October 3, 2023 20:46
@quiet-node quiet-node self-assigned this Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Test Results

198 tests  +8   192 ✔️ +6   7m 29s ⏱️ +13s
  64 suites +4       6 💤 +2 
  14 files   +1       0 ±0 

Results for commit 205e152. ± Comparison against base commit 2310dce.

@quiet-node quiet-node merged commit 30b2e4f into main Oct 3, 2023
20 checks passed
@quiet-node quiet-node deleted the 421-Export-transaction-to-CSV-feature branch October 3, 2023 23:37
mshakeg pushed a commit to mshakeg/hedera-smart-contracts that referenced this pull request Oct 14, 2023
…hashgraph#424)

* dapp-update: reworked delete transactions in main activity page

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added react-csv package

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-feat: Exporting Transactions to CSV feature complete

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
ebadiere pushed a commit that referenced this pull request Oct 16, 2023
* dapp-update: reworked delete transactions in main activity page

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added react-csv package

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-feat: Exporting Transactions to CSV feature complete

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 Tooling tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[System Contract DApp] Export transaction feature
2 participants