Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dapp-docs: added source code documentation (#438) #439

Merged
merged 31 commits into from
Oct 11, 2023

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Oct 9, 2023

Description: This PR added a new source code document which is thorough and meticulous in describing the purposes of each component within the project. Additionally, the document should include a tutorial section that provides guidance on how to integrate new system contracts into the DApp which can be found in the README.md of the source-code-document folder

Related issue(s): #438

Fixes #438

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…e DApp` to main doc README.md

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node added documentation Improvements or additions to documentation enhancement New feature or request P2 Tooling tooling labels Oct 9, 2023
@quiet-node quiet-node added this to the 0.6.0 milestone Oct 9, 2023
@quiet-node quiet-node self-assigned this Oct 9, 2023
@quiet-node quiet-node requested a review from a team as a code owner October 9, 2023 18:20
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Test Results

198 tests  ±0   192 ✔️ +2   7m 35s ⏱️ +16s
  64 suites ±0       6 💤 ±0 
  14 files   ±0       0  - 2 

Results for commit f7a9f04. ± Comparison against base commit c44c315.

♻️ This comment has been updated with latest results.

AlfredoG87
AlfredoG87 previously approved these changes Oct 10, 2023
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

system-contract-dapp-playground/package.json Outdated Show resolved Hide resolved
Nana-EC
Nana-EC previously approved these changes Oct 11, 2023
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Note the spelling issue with the directory Fredy noted.

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node dismissed stale reviews from Nana-EC and AlfredoG87 via f7a9f04 October 11, 2023 01:09
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG 👍

@quiet-node quiet-node merged commit b855d88 into main Oct 11, 2023
20 checks passed
@quiet-node quiet-node deleted the 438-phase-4-source-code-documentation- branch October 11, 2023 03:38
mshakeg pushed a commit to mshakeg/hedera-smart-contracts that referenced this pull request Oct 14, 2023
…#439)

* docs: fixed typo in TEST_SETUP.md

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added Overview to dapp README

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: init source code documentation

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase structure - folder tree document

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `__tests__` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-refactor: moved prerequisite-check into its own folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `prerequisite-check` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `public` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `confile files`

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/api/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/app/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/fonts/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/hooks/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/libs/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/styles/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/sections/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/types/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/utils/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/middleware.md` file

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/activity/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/background-gradients/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/common/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/footer/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/navbar/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/sidebar/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/toast/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/popup-wallet/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/contract-interactions/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-refactor: refactored the source-code-documentation folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added `Tutorials on How to Add a New System Contract to the DApp` to main doc README.md

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-fix(docs): fixed typo

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
ebadiere pushed a commit that referenced this pull request Oct 16, 2023
* docs: fixed typo in TEST_SETUP.md

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added Overview to dapp README

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: init source code documentation

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase structure - folder tree document

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `__tests__` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-refactor: moved prerequisite-check into its own folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `prerequisite-check` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `public` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `confile files`

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/api/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/app/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/fonts/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/hooks/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/libs/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/styles/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/sections/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/types/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/utils/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/middleware.md` file

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/activity/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/background-gradients/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/common/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/footer/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/navbar/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/sidebar/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/toast/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/popup-wallet/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added codebase walkthrough - `src/components/contract-interactions/` folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-refactor: refactored the source-code-documentation folder

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-docs: added `Tutorials on How to Add a New System Contract to the DApp` to main doc README.md

Signed-off-by: Logan Nguyen <[email protected]>

* dapp-fix(docs): fixed typo

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request P2 Tooling tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[System Contract DApp] Phase 4: Source code documentation
3 participants