-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tests for the Transactions in Solidity #453
Conversation
Test Results 17 files + 3 70 suites +6 9m 17s ⏱️ + 1m 33s For more details on these failures, see this check. Results for commit 5c8f507. ± Comparison against base commit dce4754. ♻️ This comment has been updated with latest results. |
db7ce58
to
ea0f10a
Compare
d923cbb
to
3c94e2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, some suggestions
Signed-off-by: Stefan Stefanov <[email protected]>
4b60d03
to
3514d56
Compare
Signed-off-by: Stefan Stefanov <[email protected]>
3514d56
to
141f586
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Logan Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the help here @quiet-node ;) |
* Adding tests for the Transactions in Solidity Signed-off-by: Stefan Stefanov <[email protected]> * Resolving comments. Signed-off-by: Stefan Stefanov <[email protected]> * fix: fixed test's name Signed-off-by: Logan Nguyen <[email protected]> --------- Signed-off-by: Stefan Stefanov <[email protected]> Signed-off-by: Logan Nguyen <[email protected]> Co-authored-by: Logan Nguyen <[email protected]> Signed-off-by: ebadiere <[email protected]>
Description:
Add support for transaction properties
Related issue(s):
#431
Fixes #
Notes for reviewer: