Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for the Transactions in Solidity #453

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

stefan-stefanooov
Copy link
Contributor

Description:
Add support for transaction properties

Related issue(s):
#431

Fixes #

Notes for reviewer:

@github-actions
Copy link

github-actions bot commented Oct 11, 2023

Test Results

  17 files  +  3    70 suites  +6   9m 17s ⏱️ + 1m 33s
198 tests ±  0  190 ✔️ ±  0  6 💤 ±0  2 ±0 
228 runs  +30  218 ✔️ +28  6 💤 ±0  4 +2 

For more details on these failures, see this check.

Results for commit 5c8f507. ± Comparison against base commit dce4754.

♻️ This comment has been updated with latest results.

@stefan-stefanooov stefan-stefanooov force-pushed the 431-solidity-support-transaction-properties branch from db7ce58 to ea0f10a Compare October 11, 2023 14:49
@stefan-stefanooov stefan-stefanooov self-assigned this Oct 11, 2023
@stefan-stefanooov stefan-stefanooov added the Limechain Items for Limechain team label Oct 11, 2023
@stefan-stefanooov stefan-stefanooov added this to the 0.6.0 milestone Oct 11, 2023
@stefan-stefanooov stefan-stefanooov force-pushed the 431-solidity-support-transaction-properties branch 4 times, most recently from d923cbb to 3c94e2f Compare October 12, 2023 08:22
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, some suggestions

test/solidity/transaction/transaction.js Show resolved Hide resolved
test/solidity/transaction/transaction.js Outdated Show resolved Hide resolved
contracts/solidity/transaction/Secondary.sol Outdated Show resolved Hide resolved
@stefan-stefanooov stefan-stefanooov force-pushed the 431-solidity-support-transaction-properties branch from 4b60d03 to 3514d56 Compare October 13, 2023 13:06
Signed-off-by: Stefan Stefanov <[email protected]>
@stefan-stefanooov stefan-stefanooov force-pushed the 431-solidity-support-transaction-properties branch from 3514d56 to 141f586 Compare October 13, 2023 13:51
Nana-EC
Nana-EC previously approved these changes Oct 13, 2023
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-stefanooov stefan-stefanooov added enhancement New feature or request EVM evm related labels Oct 13, 2023
Signed-off-by: Logan Nguyen <[email protected]>
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quiet-node quiet-node merged commit 29f948c into main Oct 13, 2023
19 of 20 checks passed
@quiet-node quiet-node deleted the 431-solidity-support-transaction-properties branch October 13, 2023 23:43
@stefan-stefanooov
Copy link
Contributor Author

Thanks for the help here @quiet-node ;)

ebadiere pushed a commit that referenced this pull request Oct 16, 2023
* Adding tests for the Transactions in Solidity

Signed-off-by: Stefan Stefanov <[email protected]>

* Resolving comments.

Signed-off-by: Stefan Stefanov <[email protected]>

* fix: fixed test's name

Signed-off-by: Logan Nguyen <[email protected]>

---------

Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Co-authored-by: Logan Nguyen <[email protected]>
Signed-off-by: ebadiere <[email protected]>
@bibitibooo1 bibitibooo1 removed the Limechain Items for Limechain team label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related P1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Transaction properties
5 participants