-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement precompile mock contracts and foundry mock util test contracts #462
Conversation
Signed-off-by: Mo Shaikjee <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
Hey @Nana-EC I opened this PR as the git rebase to sign-off all commits wasn't clean and ended up showing a bunch of other changes. There are still quite a lot of TODOs documented in the code, when I free up a bit I'll create issues for those and address them. |
Np. |
@Nana-EC do you want to merge this PR as is or should I first remove the TODOs scattered throughout the code? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor docs, naming and workflow changes to make it ready to get in
@mshakeg gonna work with you to get this in hopefuly this week. |
Signed-off-by: Mo Shaikjee <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
@Nana-EC thanks for the review, I added a husky hook to prevent committing without signing off as I don't always remember to do so. |
@mshakeg Looks good to go. Just waiting on CI to pass and I'll merge this in. |
And just after I commented of course all the CI tests fail - https://github.com/hashgraph/hedera-smart-contracts/actions/runs/6546507450/job/17787629512?pr=462 |
Signed-off-by: Mo Shaikjee <[email protected]>
@Nana-EC thanks, will do. Once this is in, I'll continue with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incredible work, I will have to come back later to complete review, but overall it looks really good.
Only 2 nits and 1 question.
Signed-off-by: Mo Shaikjee <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Nice work
Description
Replaces #236 for a cleaner review.