Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for control structures #463

Merged
merged 5 commits into from
Nov 3, 2023

Conversation

konstantinabl
Copy link
Contributor

@konstantinabl konstantinabl commented Oct 16, 2023

Description:

This PR adds:

  • New contract with functions to test control structures
  • New test file for testing this contract

Related issue(s):

Fixes #448

Notes for reviewer:

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Test Results

  18 files  +  4    85 suites  +21   10m 38s ⏱️ + 3m 2s
198 tests ±  0  190 ✔️  -   1  6 💤 ±0  2 +1 
254 runs  +56  244 ✔️ +53  6 💤 ±0  4 +3 

For more details on these failures, see this check.

Results for commit c53ff14. ± Comparison against base commit f0013da.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some nits but overall LGTM!

contracts/solidity/control/ControlStructures.sol Outdated Show resolved Hide resolved
contracts/solidity/control/ControlStructures.sol Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
Can we set a max on the loops though, unless it disrupts the desired test goal.

@konstantinabl konstantinabl force-pushed the 448-solidity-support-control-structures branch from cec5b85 to 3144fcb Compare October 18, 2023 08:33
@konstantinabl konstantinabl force-pushed the 448-solidity-support-control-structures branch 2 times, most recently from a68e697 to edd617d Compare October 19, 2023 10:33
Nana-EC
Nana-EC previously approved these changes Oct 19, 2023
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 minor items

contracts/solidity/control/ControlStructures.sol Outdated Show resolved Hide resolved
test/solidity/control/control.js Show resolved Hide resolved
Nana-EC
Nana-EC previously approved these changes Nov 3, 2023
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Copy link
Contributor

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@konstantinabl konstantinabl merged commit 82d1cc5 into main Nov 3, 2023
19 of 21 checks passed
@konstantinabl konstantinabl deleted the 448-solidity-support-control-structures branch November 3, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Solidity Support] control structures
5 participants