Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABI Encoding tests. #466

Merged
merged 2 commits into from
Oct 16, 2023
Merged

ABI Encoding tests. #466

merged 2 commits into from
Oct 16, 2023

Conversation

ebadiere
Copy link
Contributor

Test covering ABI Encoding.

Related issue(s): #432

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ebadiere
ABI Encoding tests.
cd51ab8 
Signed-off-by: ebadiere <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

Test Results

198 tests  ±0   192 ✔️ ±0   7m 40s ⏱️ -3s
  64 suites ±0       6 💤 ±0 
  14 files   ±0       0 ❌ ±0 

Results for commit baf1507. ± Comparison against base commit 71d3c46.

♻️ This comment has been updated with latest results.

AlfredoG87
AlfredoG87 previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

contracts/solidity/encoding/Receiver.sol Outdated Show resolved Hide resolved
contracts/solidity/encoding/Sender.sol Outdated Show resolved Hide resolved
AlfredoG87
AlfredoG87 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebadiere ebadiere merged commit b1a5fe1 into main Oct 16, 2023
20 checks passed
@ebadiere ebadiere deleted the 432-abi-encoding-and-decoding-revisited branch October 16, 2023 22:34
@ebadiere ebadiere self-assigned this Oct 17, 2023
@ebadiere ebadiere added the enhancement New feature or request label Oct 17, 2023
@ebadiere ebadiere added this to the 0.6.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlfredoG87 AlfredoG87 AlfredoG87 approved these changes

@AleksandrinaAleksieva AleksandrinaAleksieva Awaiting requested review from AleksandrinaAleksieva

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@natanasow natanasow Awaiting requested review from natanasow natanasow is a code owner

@yiliev0 yiliev0 Awaiting requested review from yiliev0 yiliev0 is a code owner

@Nana-EC Nana-EC Awaiting requested review from Nana-EC

Assignees

@ebadiere ebadiere

Labels
enhancement New feature or request
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ebadiere @AlfredoG87