-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tests for inheritance #474
Merged
stefan-stefanooov
merged 3 commits into
main
from
446-solidity-support-inheritance-operations
Oct 18, 2023
Merged
Adding tests for inheritance #474
stefan-stefanooov
merged 3 commits into
main
from
446-solidity-support-inheritance-operations
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-stefanooov
requested review from
AlfredoG87,
AleksandrinaAleksieva,
ebadiere,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0,
a team and
Nana-EC
as code owners
October 17, 2023 08:27
stefan-stefanooov
force-pushed
the
446-solidity-support-inheritance-operations
branch
from
October 17, 2023 09:46
48e5001
to
2bc1040
Compare
natanasow
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some nits
natanasow
reviewed
Oct 17, 2023
natanasow
reviewed
Oct 17, 2023
konstantinabl
previously approved these changes
Oct 18, 2023
Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Stefan Stefanov <[email protected]>
stefan-stefanooov
force-pushed
the
446-solidity-support-inheritance-operations
branch
from
October 18, 2023 12:52
40b84a0
to
165532a
Compare
Nothing changed in this revision. Fixing merge conflicts. |
natanasow
approved these changes
Oct 18, 2023
stefan-stefanooov
deleted the
446-solidity-support-inheritance-operations
branch
October 18, 2023 13:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding tests for inheritance
Related issue(s):
[Solidity Support] Inheritance operations#446