Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for inheritance #474

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

stefan-stefanooov
Copy link
Contributor

Description:
Adding tests for inheritance

Related issue(s):
[Solidity Support] Inheritance operations#446

@stefan-stefanooov stefan-stefanooov linked an issue Oct 17, 2023 that may be closed by this pull request
@stefan-stefanooov stefan-stefanooov self-assigned this Oct 17, 2023
@stefan-stefanooov stefan-stefanooov added the Limechain Items for Limechain team label Oct 17, 2023
@stefan-stefanooov stefan-stefanooov added this to the 0.6.0 milestone Oct 17, 2023
@stefan-stefanooov stefan-stefanooov added enhancement New feature or request P1 EVM evm related labels Oct 17, 2023
@stefan-stefanooov stefan-stefanooov force-pushed the 446-solidity-support-inheritance-operations branch from 48e5001 to 2bc1040 Compare October 17, 2023 09:46
@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Test Results

198 tests  ±0   192 ✔️ ±0   7m 38s ⏱️ -11s
  64 suites ±0       6 💤 ±0 
  14 files   ±0       0 ±0 

Results for commit 165532a. ± Comparison against base commit 6f7383f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nits

test/solidity/inheritance/inheritance.js Outdated Show resolved Hide resolved
test/solidity/inheritance/inheritance.js Outdated Show resolved Hide resolved
test/solidity/inheritance/inheritance.js Outdated Show resolved Hide resolved
contracts/solidity/inhetitance/Main.sol Outdated Show resolved Hide resolved
konstantinabl
konstantinabl previously approved these changes Oct 18, 2023
Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Stefan Stefanov <[email protected]>
@stefan-stefanooov stefan-stefanooov force-pushed the 446-solidity-support-inheritance-operations branch from 40b84a0 to 165532a Compare October 18, 2023 12:52
@stefan-stefanooov
Copy link
Contributor Author

stefan-stefanooov commented Oct 18, 2023

Nothing changed in this revision. Fixing merge conflicts.

@stefan-stefanooov stefan-stefanooov merged commit 6ed7741 into main Oct 18, 2023
21 checks passed
@stefan-stefanooov stefan-stefanooov deleted the 446-solidity-support-inheritance-operations branch October 18, 2023 13:11
@bibitibooo1 bibitibooo1 removed the Limechain Items for Limechain team label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related P1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Inheritance operations
4 participants