Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests for parameter restructuring and assignment #498

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

konstantinabl
Copy link
Contributor

@konstantinabl konstantinabl commented Oct 18, 2023

Description:

  • Adds contract for destructuring return values
  • Adds contract for assignment of reference types
  • Adds test for abovementioned contracts

Related issue(s):

Fixes #470

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Test Results

  16 files  +  2    67 suites  +4   8m 35s ⏱️ + 1m 7s
195 tests ±  0  187 ✔️  -   1  6 💤 ±0  2 +1 
215 runs  +20  205 ✔️ +17  6 💤 ±0  4 +3 

For more details on these failures, see this check.

Results for commit 0e51e02. ± Comparison against base commit 271fa2e.

♻️ This comment has been updated with latest results.

@konstantinabl konstantinabl force-pushed the 470-solidity-support-param-assignments branch 2 times, most recently from 2fd106d to de8a6d5 Compare October 18, 2023 11:57
natanasow
natanasow previously approved these changes Oct 18, 2023
Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; approved with some optional nits

@Nana-EC Nana-EC added this to the 0.6.0 milestone Oct 18, 2023
@Nana-EC Nana-EC added enhancement New feature or request P1 EVM evm related labels Oct 18, 2023
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some suggestions

test/solidity/assignments/assignments.js Outdated Show resolved Hide resolved
test/solidity/assignments/assignments.js Show resolved Hide resolved
test/solidity/assignments/assignments.js Show resolved Hide resolved
@konstantinabl konstantinabl force-pushed the 470-solidity-support-param-assignments branch 2 times, most recently from dae3fe4 to eff0bfa Compare October 19, 2023 10:16
@konstantinabl konstantinabl requested a review from Nana-EC October 19, 2023 10:21
Nana-EC
Nana-EC previously approved these changes Oct 23, 2023
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Missing js file license header

@konstantinabl konstantinabl force-pushed the 470-solidity-support-param-assignments branch 4 times, most recently from cff05c7 to f33cd53 Compare October 30, 2023 13:15
Nana-EC
Nana-EC previously approved these changes Nov 1, 2023
Nana-EC
Nana-EC previously approved these changes Nov 3, 2023
Nana-EC
Nana-EC previously approved these changes Nov 3, 2023
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl requested a review from Nana-EC November 6, 2023 15:24
@konstantinabl konstantinabl merged commit 0481257 into main Nov 6, 2023
20 of 21 checks passed
@konstantinabl konstantinabl deleted the 470-solidity-support-param-assignments branch November 6, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Param assignments
4 participants