-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tests for parameter restructuring and assignment #498
Conversation
Test Results 16 files + 2 67 suites +4 8m 35s ⏱️ + 1m 7s For more details on these failures, see this check. Results for commit 0e51e02. ± Comparison against base commit 271fa2e. ♻️ This comment has been updated with latest results. |
2fd106d
to
de8a6d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; approved with some optional nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some suggestions
dae3fe4
to
eff0bfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Missing js file license header
cff05c7
to
f33cd53
Compare
f33cd53
to
ddb4874
Compare
ddb4874
to
7d6075d
Compare
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
7d6075d
to
0e51e02
Compare
Description:
Related issue(s):
Fixes #470