-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tests for NonExistant account #501
Adding tests for NonExistant account #501
Conversation
399e2da
to
dbf2a30
Compare
Test Results 16 files + 2 68 suites +4 8m 44s ⏱️ + 1m 1s For more details on these failures, see this check. Results for commit 159e7ab. ± Comparison against base commit e7dd7b7. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some nits
c981c01
to
bc90396
Compare
be113d0
to
2391b73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
Currently the tests use a non existing address as the base for the call.
What about when the calls is to a non existing address e.g. a contract creation for an address that doesn't exist or a function call (code size or balance) on an address that doesn't exist. The last example might already be covered in other recent solidity code so double check the epic or current tests.
Signed-off-by: Stefan Stefanov <[email protected]>
2391b73
to
53ee9d8
Compare
Signed-off-by: Stefan Stefanov <[email protected]>
53ee9d8
to
159e7ab
Compare
Addressed in the new version :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Adding tests for NonExistant account
Related issue(s):
#482