Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for NonExistant account #501

Merged

Conversation

stefan-stefanooov
Copy link
Contributor

Description:
Adding tests for NonExistant account

Related issue(s):
#482

@stefan-stefanooov stefan-stefanooov added enhancement New feature or request P1 Limechain Items for Limechain team EVM evm related labels Oct 18, 2023
@stefan-stefanooov stefan-stefanooov added this to the 0.6.0 milestone Oct 18, 2023
@stefan-stefanooov stefan-stefanooov self-assigned this Oct 18, 2023
@stefan-stefanooov stefan-stefanooov linked an issue Oct 18, 2023 that may be closed by this pull request
@stefan-stefanooov stefan-stefanooov requested review from a team and Nana-EC as code owners October 18, 2023 13:03
@stefan-stefanooov stefan-stefanooov force-pushed the 482-solidity-support-non-existing-accounts-support branch from 399e2da to dbf2a30 Compare October 18, 2023 13:03
@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Test Results

  16 files  +  2    68 suites  +4   8m 44s ⏱️ + 1m 1s
198 tests +  2  191 ✔️ +  3  6 💤 ±0  1  - 1 
218 runs  +20  210 ✔️ +20  6 💤 ±0  2 ±0 

For more details on these failures, see this check.

Results for commit 159e7ab. ± Comparison against base commit e7dd7b7.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
"before all" hook for "should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via precompile" ‑ HIP583 Test Suite - Ethereum Transfer TX via Precompile Non-Fungible Token Test "before all" hook for "should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via precompile"
should test that can make non-fungible token transfer via precompile from hollow account to another ‑ HIP583 Test Suite - Ethereum Transfer TX via Precompile Non-Fungible Token Test should test that can make non-fungible token transfer via precompile from hollow account to another
should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via precompile ‑ HIP583 Test Suite - Ethereum Transfer TX via Precompile Non-Fungible Token Test should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via precompile
should test that second transfer non-fungible tokens via precompile to the hollow account is successful ‑ HIP583 Test Suite - Ethereum Transfer TX via Precompile Non-Fungible Token Test should test that second transfer non-fungible tokens via precompile to the hollow account is successful

♻️ This comment has been updated with latest results.

Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some nits

contracts/solidity/account/NonExisting.sol Outdated Show resolved Hide resolved
contracts/solidity/account/NonExisting.sol Outdated Show resolved Hide resolved
contracts/solidity/account/NonExisting.sol Outdated Show resolved Hide resolved
test/solidity/account/nonExisting.js Outdated Show resolved Hide resolved
test/solidity/account/nonExisting.js Outdated Show resolved Hide resolved
test/solidity/account/nonExisting.js Outdated Show resolved Hide resolved
contracts/solidity/account/NonExisting.sol Show resolved Hide resolved
test/solidity/account/nonExisting.js Outdated Show resolved Hide resolved
@stefan-stefanooov stefan-stefanooov force-pushed the 482-solidity-support-non-existing-accounts-support branch from c981c01 to bc90396 Compare October 19, 2023 11:17
@stefan-stefanooov stefan-stefanooov force-pushed the 482-solidity-support-non-existing-accounts-support branch 2 times, most recently from be113d0 to 2391b73 Compare October 20, 2023 06:55
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG
Currently the tests use a non existing address as the base for the call.
What about when the calls is to a non existing address e.g. a contract creation for an address that doesn't exist or a function call (code size or balance) on an address that doesn't exist. The last example might already be covered in other recent solidity code so double check the epic or current tests.

@stefan-stefanooov stefan-stefanooov force-pushed the 482-solidity-support-non-existing-accounts-support branch from 2391b73 to 53ee9d8 Compare October 26, 2023 10:44
Signed-off-by: Stefan Stefanov <[email protected]>
@stefan-stefanooov stefan-stefanooov force-pushed the 482-solidity-support-non-existing-accounts-support branch from 53ee9d8 to 159e7ab Compare October 27, 2023 12:09
@stefan-stefanooov
Copy link
Contributor Author

LG Currently the tests use a non existing address as the base for the call. What about when the calls is to a non existing address e.g. a contract creation for an address that doesn't exist or a function call (code size or balance) on an address that doesn't exist. The last example might already be covered in other recent solidity code so double check the epic or current tests.

Addressed in the new version :)

Copy link
Contributor

@natanasow natanasow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefan-stefanooov stefan-stefanooov merged commit 79d153c into main Nov 2, 2023
20 of 21 checks passed
@stefan-stefanooov stefan-stefanooov deleted the 482-solidity-support-non-existing-accounts-support branch November 2, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related Limechain Items for Limechain team P1
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Non existing accounts support
3 participants