487 Solidity Support Modifiers #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Test Results 15 files + 1 66 suites +2 8m 20s ⏱️ +50s For more details on these failures, see this check. Results for commit c8f4d58. ± Comparison against base commit 46ee829. ♻️ This comment has been updated with latest results. |
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
ebadiere
requested review from
AlfredoG87,
AleksandrinaAleksieva,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0,
a team and
Nana-EC
as code owners
Nana-EC
reviewed
Oct 26, 2023
contracts/solidity/modifiers/A.sol
Outdated
| @@ -0,0 +1,9 @@ | |||
| // SPDX-License-Identifier: MIT | |||
There was a problem hiding this comment.
Use Apache 2.0 license for all
Signed-off-by: ebadiere <[email protected]>
Nana-EC
approved these changes
Nov 7, 2023
| expect(await contractB.getData()).to.equal(79); | ||
| expect(await contractB.show()).to.equal("This is the overriding contract B"); | ||
| }); | ||
|
|
There was a problem hiding this comment.
nit: a few of these have an extra line before the final closing bracket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solidity modifiers coverage
Fixes #487