Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added PaymentChannel smart contract (#493) #509

Merged
merged 2 commits into from
Oct 23, 2023
Merged

feat: added PaymentChannel smart contract (#493) #509

merged 2 commits into from
Oct 23, 2023

Conversation

quiet-node
Copy link
Member

Description:

  • added a new PaymentChannel contract
  • added PaymentChannelHelper class to sign payment message off-chain
  • added a suite of unit tests to cover PaymentChannel contract

Related issue(s): #493

Fixes #493

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node self-assigned this Oct 20, 2023
@quiet-node quiet-node added enhancement New feature or request P2 Tooling tooling labels Oct 20, 2023
@quiet-node quiet-node added this to the 0.6.0 milestone Oct 20, 2023
@quiet-node quiet-node force-pushed the 493-Payment-Channel-example branch from 9b0cbd4 to 0627c46 Compare October 20, 2023 15:31
@github-actions
Copy link

github-actions bot commented Oct 20, 2023 •
edited
Loading

Test Results

198 tests  +1   192 ✔️ +2   7m 50s ⏱️ +10s
  64 suites +2       6 💤 ±0 
  14 files   +1       0 ❌  - 1 

Results for commit 396ecbb. ± Comparison against base commit 85a0600.

♻️ This comment has been updated with latest results.

@quiet-node
fix: fixed typo
396ecbb 
Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node requested a review from ebadiere October 20, 2023 21:03
ebadiere
ebadiere approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@quiet-node quiet-node merged commit ab035ef into main Oct 23, 2023
21 checks passed
@quiet-node quiet-node deleted the 493-Payment-Channel-example branch October 23, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebadiere ebadiere ebadiere approved these changes

@AlfredoG87 AlfredoG87 Awaiting requested review from AlfredoG87

@AleksandrinaAleksieva AleksandrinaAleksieva Awaiting requested review from AleksandrinaAleksieva

@georgi-l95 georgi-l95 Awaiting requested review from georgi-l95 georgi-l95 is a code owner

@Ivo-Yankov Ivo-Yankov Awaiting requested review from Ivo-Yankov Ivo-Yankov is a code owner

@natanasow natanasow Awaiting requested review from natanasow natanasow is a code owner

@yiliev0 yiliev0 Awaiting requested review from yiliev0 yiliev0 is a code owner

@Nana-EC Nana-EC Awaiting requested review from Nana-EC

Assignees

@quiet-node quiet-node

Labels
enhancement New feature or request P2 Tooling tooling
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Payment Channel example
2 participants
@quiet-node @ebadiere