Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates tests for panic errors support #510

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

konstantinabl
Copy link
Contributor

@konstantinabl konstantinabl commented Oct 20, 2023

Description:

Creates tests to check panic errors support
Related issue(s):

Fixes #483

@konstantinabl konstantinabl linked an issue Oct 20, 2023 that may be closed by this pull request
@konstantinabl konstantinabl force-pushed the 483-solidity-support-panic-errors branch 2 times, most recently from 2f45016 to 2a5a597 Compare October 20, 2023 08:30
@github-actions
Copy link

github-actions bot commented Oct 20, 2023

Test Results

  15 files  +1    65 suites  +2   7m 34s ⏱️ -1s
195 tests ±0  188 ✔️  - 1  6 💤 ±0  1 +1 
202 runs  +7  195 ✔️ +6  6 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 4aa04b3. ± Comparison against base commit 2505c08.

♻️ This comment has been updated with latest results.

@konstantinabl konstantinabl force-pushed the 483-solidity-support-panic-errors branch 2 times, most recently from 2700472 to 1ede130 Compare November 1, 2023 20:33
@konstantinabl konstantinabl marked this pull request as ready for review November 1, 2023 20:34
@konstantinabl konstantinabl changed the title Drafts tests for panic errors support Creates tests for panic errors support Nov 1, 2023
@konstantinabl konstantinabl force-pushed the 483-solidity-support-panic-errors branch 2 times, most recently from 22e1125 to 68f4c8e Compare November 3, 2023 09:40
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.
A few nits

test/constants.js Outdated Show resolved Hide resolved
contracts/solidity/errors/Panic.sol Outdated Show resolved Hide resolved
test/solidity/errors/panicErrors.js Outdated Show resolved Hide resolved
@konstantinabl konstantinabl force-pushed the 483-solidity-support-panic-errors branch 2 times, most recently from 48a9385 to f10cbb6 Compare November 3, 2023 14:30
Nana-EC
Nana-EC previously approved these changes Nov 3, 2023
@konstantinabl konstantinabl force-pushed the 483-solidity-support-panic-errors branch 2 times, most recently from 3507098 to fca9cec Compare November 6, 2023 12:04
georgi-l95
georgi-l95 previously approved these changes Nov 6, 2023
Nana-EC
Nana-EC previously approved these changes Nov 7, 2023
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, please update PR with descriptions

Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
@konstantinabl konstantinabl force-pushed the 483-solidity-support-panic-errors branch from 8de527f to 4aa04b3 Compare November 7, 2023 14:12
@konstantinabl konstantinabl merged commit f19ed6d into main Nov 7, 2023
19 of 21 checks passed
@konstantinabl konstantinabl deleted the 483-solidity-support-panic-errors branch November 7, 2023 14:31
@konstantinabl konstantinabl restored the 483-solidity-support-panic-errors branch November 8, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Panic Errors
3 participants