-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added bitwise coverage solidity example contract (#519) #522
Conversation
6fda40e
to
17edf4d
Compare
Test Results 15 files + 1 66 suites +2 8m 11s ⏱️ +28s For more details on these failures, see this check. Results for commit afbaed5. ± Comparison against base commit e7dd7b7. This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Signed-off-by: Logan Nguyen <[email protected]>
17edf4d
to
6d0f2be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Blank line at the end of the file. Otherwise LG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only the Nit that Eric left and a Question.
Looks good!
const { expect } = require('chai') | ||
const { ethers } = require('hardhat') | ||
|
||
describe('@solidityequiv5 Bitwise Tests', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are we deciding what number to put after the solidityequiv
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah for this I thought with this new batch of test suites for Yul support I just give it a new number. I believe before the Yul support, it went up to solidityequiv4
so I just made it solidityequiv5
Signed-off-by: Logan Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
License fix
@@ -0,0 +1,65 @@ | |||
// SPDX-License-Identifier: UNLICENSED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Apache 2.0 for all licenses
Signed-off-by: Logan Nguyen <[email protected]>
db9953b
to
afbaed5
Compare
Description:
Related issue(s): #519
Fixes #519
Notes for reviewer:
Checklist