Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added modular solidity example contract (#494) #523

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Oct 23, 2023

Description:

  • added Token modular contract to showcase in-line assembly math operations

  • added unit tests to cover Token modular contract

Related issue(s): #494

Fixes #494

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Test Results

198 tests  ±0   192 ✔️ +1   7m 34s ⏱️ -8s
  64 suites ±0       6 💤 ±0 
  14 files   ±0       0  - 1 

Results for commit 54d5093. ± Comparison against base commit ab035ef.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Blank line at the end of each file?

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@AlfredoG87
Copy link
Contributor

LG

Just blank line missing

@quiet-node quiet-node merged commit db6afbb into main Oct 25, 2023
21 checks passed
@quiet-node quiet-node deleted the 494-Modular-Contract-Example branch October 25, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related P2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Modular Contract Example
3 participants