Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added DataAllocation solidity example contract #525

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

quiet-node
Copy link
Member

@quiet-node quiet-node commented Oct 23, 2023

Description:

  • added DataAllocation solidity example contract to cover below opcodes

    • mload(p)
    • mstore(p, v)
    • mstore8(p, v)
    • sload(p)
    • sstore(p, v)
  • added unit tests to cover DataAllocation contract

Related issue(s): #520

Fixes #520

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Test Results

  18 files  +  4    72 suites  +8   10m 6s ⏱️ + 2m 24s
198 tests ±  0  191 ✔️ ±  0  6 💤 ±0  1 ±0 
238 runs  +40  228 ✔️ +37  6 💤 ±0  4 +3 

For more details on these failures, see this check.

Results for commit 8d54124. ± Comparison against base commit ab035ef.

♻️ This comment has been updated with latest results.

Signed-off-by: Logan Nguyen <[email protected]>

expect(result).to.eq(V)
})
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Extra line.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lg
Fix license

@@ -0,0 +1,43 @@
// SPDX-License-Identifier: UNLICENSED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache 2.0

@quiet-node quiet-node requested a review from Nana-EC October 26, 2023 03:50
@quiet-node quiet-node merged commit 20fee21 into main Nov 1, 2023
20 of 21 checks passed
@quiet-node quiet-node deleted the 520-data-allocation branch November 1, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related P2 Tooling tooling
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Solidity Assembly Yul support] data allocation
3 participants