Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added ContractCreator solidity example contract (#530) #531

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

quiet-node
Copy link
Member

Description:

  • added ContractCreator soldiity example contract to cover
    • create(v, p, n)
    • create2(v, p, n, s)
  • added unit tests to cover ContractCreator contract

Related issue(s):

Fixes #530

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Test Results

  16 files  +  2    88 suites  +24   10m 32s ⏱️ + 2m 49s
198 tests +  2  188 ✔️ ±  0  6 💤 ±0  4 +2 
266 runs  +68  256 ✔️ +66  6 💤 ±0  4 +2 

For more details on these failures, see this check.

Results for commit bee001a. ± Comparison against base commit e7dd7b7.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
"before all" hook for "should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via precompile" ‑ HIP583 Test Suite - Ethereum Transfer TX via Precompile Non-Fungible Token Test "before all" hook for "should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via precompile"
should test that can make non-fungible token transfer via precompile from hollow account to another ‑ HIP583 Test Suite - Ethereum Transfer TX via Precompile Non-Fungible Token Test should test that can make non-fungible token transfer via precompile from hollow account to another
should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via precompile ‑ HIP583 Test Suite - Ethereum Transfer TX via Precompile Non-Fungible Token Test should test that hollow account is created and the amount of non-fungible tokens is correctly transferred via precompile
should test that second transfer non-fungible tokens via precompile to the hollow account is successful ‑ HIP583 Test Suite - Ethereum Transfer TX via Precompile Non-Fungible Token Test should test that second transfer non-fungible tokens via precompile to the hollow account is successful

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIx license and extra extra line

@quiet-node quiet-node force-pushed the 530-Contract-Creator branch from e662c9a to bee001a Compare October 26, 2023 03:47
@quiet-node quiet-node requested a review from Nana-EC October 26, 2023 03:49
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@quiet-node quiet-node merged commit fca678a into main Nov 7, 2023
20 of 21 checks passed
@quiet-node quiet-node deleted the 530-Contract-Creator branch November 7, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Solidity Assembly Yul support] Contract Creator
2 participants