-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tests for the Simple Auction smart contract. #532
Adding tests for the Simple Auction smart contract. #532
Conversation
9f42dcc
to
844cc94
Compare
844cc94
to
05dbbb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG but are the sleeps necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explore polling logic instead of sleeps
This might be an item to have that's shared for all tests.
@ebadiere may have explored this also
05dbbb9
to
473ff62
Compare
Signed-off-by: Stefan Stefanov <[email protected]>
Signed-off-by: Stefan Stefanov <[email protected]>
473ff62
to
eefbf03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, no need to check in the dbg.json
file
@@ -0,0 +1,4 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to check this file in
Description:
Adding tests for the Simple Auction smart contract.
Related issue(s):
[Solidity Support] Simple auction example#489