Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for the Simple Auction smart contract. #532

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

stefan-stefanooov
Copy link
Contributor

Description:
Adding tests for the Simple Auction smart contract.

Related issue(s):
[Solidity Support] Simple auction example#489

@stefan-stefanooov stefan-stefanooov linked an issue Oct 26, 2023 that may be closed by this pull request
@stefan-stefanooov stefan-stefanooov self-assigned this Oct 26, 2023
@stefan-stefanooov stefan-stefanooov added enhancement New feature or request P2 Limechain Items for Limechain team labels Oct 26, 2023
@stefan-stefanooov stefan-stefanooov added this to the 0.6.0 milestone Oct 26, 2023
@stefan-stefanooov stefan-stefanooov added the EVM evm related label Oct 26, 2023
@github-actions
Copy link

github-actions bot commented Oct 26, 2023

Test Results

196 tests  ±0   190 ✔️ +3   7m 5s ⏱️ -2s
  64 suites ±0       6 💤 ±0 
  14 files   ±0       0  - 3 

Results for commit eefbf03. ± Comparison against base commit 787d721.

♻️ This comment has been updated with latest results.

Nana-EC
Nana-EC previously approved these changes Nov 3, 2023
@stefan-stefanooov stefan-stefanooov force-pushed the 489-solidity-support-simple-auction-example branch 2 times, most recently from 9f42dcc to 844cc94 Compare November 7, 2023 13:33
@stefan-stefanooov stefan-stefanooov force-pushed the 489-solidity-support-simple-auction-example branch from 844cc94 to 05dbbb9 Compare November 7, 2023 14:58
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG but are the sleeps necessary?

test/solidity/simple-auction/simple-auction.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explore polling logic instead of sleeps
This might be an item to have that's shared for all tests.
@ebadiere may have explored this also

@stefan-stefanooov stefan-stefanooov force-pushed the 489-solidity-support-simple-auction-example branch from 05dbbb9 to 473ff62 Compare November 13, 2023 08:09
@stefan-stefanooov stefan-stefanooov force-pushed the 489-solidity-support-simple-auction-example branch from 473ff62 to eefbf03 Compare November 16, 2023 13:27
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, no need to check in the dbg.json file

@@ -0,0 +1,4 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to check this file in

@stefan-stefanooov stefan-stefanooov merged commit 39e16fa into main Nov 21, 2023
21 checks passed
@stefan-stefanooov stefan-stefanooov deleted the 489-solidity-support-simple-auction-example branch November 21, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request EVM evm related Limechain Items for Limechain team P2
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Solidity Support] Simple auction example
4 participants