-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhanced retries. Renamed functions. Bumped down retries to see how it behaves in CI. #584
Conversation
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Test Results 15 files + 1 81 suites +9 9m 17s ⏱️ +50s For more details on these failures, see this check. Results for commit 9d01bfa. ± Comparison against base commit c39baee. ♻️ This comment has been updated with latest results. |
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: Eric Badiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
…edera-smart-contracts into 571-polling-required Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question around the loop logic
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some improvement suggestions
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there.
Update pollForLastEvent()
Signed-off-by: ebadiere <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update PR title and description to match changes
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Signed-off-by: ebadiere <[email protected]>
Bumped down retries.
Related issue(s): #571
Fixes #