Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhanced retries. Renamed functions. Bumped down retries to see how it behaves in CI. #584

Merged
merged 17 commits into from
Jan 8, 2024

Conversation

ebadiere
Copy link
Contributor

@ebadiere ebadiere commented Nov 8, 2023

Bumped down retries.

Related issue(s): #571

Fixes #

@ebadiere ebadiere added the bug Something isn't working label Nov 8, 2023
@ebadiere ebadiere added this to the 0.7.0 milestone Nov 8, 2023
@ebadiere ebadiere self-assigned this Nov 8, 2023
Copy link

github-actions bot commented Nov 9, 2023

Test Results

  15 files  +  1    81 suites  +9   9m 17s ⏱️ +50s
243 tests ±  0  236 ✔️ ±  0  6 💤 ±0  1 ±0 
266 runs  +23  257 ✔️ +21  8 💤 +2  1 ±0 

For more details on these failures, see this check.

Results for commit 9d01bfa. ± Comparison against base commit c39baee.

♻️ This comment has been updated with latest results.

@ebadiere ebadiere marked this pull request as ready for review November 10, 2023 15:32
@ebadiere ebadiere requested a review from Nana-EC November 10, 2023 16:22
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question around the loop logic

utils/helpers.js Outdated Show resolved Hide resolved
utils/helpers.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvement suggestions

test/safe-hts-precompile/SafeHTS.js Show resolved Hide resolved
utils/helpers.js Outdated Show resolved Hide resolved
utils/helpers.js Outdated Show resolved Hide resolved
utils/helpers.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there.
Update pollForLastEvent()

utils/helpers.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR title and description to match changes

@ebadiere ebadiere changed the title Bumping down retries to see how it behaves in CI. feat: Enhanced retries. Renamed functions. Bumped down retries to see how it behaves in CI. Dec 18, 2023
@ebadiere ebadiere requested a review from Nana-EC December 18, 2023 21:29
@ebadiere ebadiere merged commit 44cd14b into main Jan 8, 2024
22 of 23 checks passed
@ebadiere ebadiere deleted the 571-polling-required branch January 8, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants