Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [OZ] ERC-2612 - Permit #606

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Conversation

stefan-stefanooov
Copy link
Contributor

@stefan-stefanooov stefan-stefanooov commented Nov 22, 2023

Description:
Adding tests for [OZ] ERC-2612 - Permit allowing approvals to be made via signatures, as defined in

Related issue(s):
#564

@stefan-stefanooov stefan-stefanooov added Limechain Items for Limechain team EVM evm related Tooling tooling labels Nov 22, 2023
@stefan-stefanooov stefan-stefanooov added this to the 0.7.0 milestone Nov 22, 2023
@stefan-stefanooov stefan-stefanooov self-assigned this Nov 22, 2023
@stefan-stefanooov stefan-stefanooov linked an issue Nov 22, 2023 that may be closed by this pull request
Copy link

github-actions bot commented Nov 22, 2023

Test Results

  16 files  +  2    82 suites  +14   9m 22s ⏱️ + 1m 39s
214 tests ±  0  207 ✔️ +  1    6 💤 ±0  1  - 1 
246 runs  +32  234 ✔️ +28  10 💤 +4  2 ±0 

For more details on these failures, see this check.

Results for commit c98c85f. ± Comparison against base commit dca9ec5.

♻️ This comment has been updated with latest results.

Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG but some comments

contracts/solidity/oz/ERC-2612/ERC2612.sol Outdated Show resolved Hide resolved
contracts/solidity/oz/ERC-2771/ERC2771Forward.sol Outdated Show resolved Hide resolved
test/solidity/oz/ERC-2612/erc-2612.js Outdated Show resolved Hide resolved
test/solidity/oz/ERC-2612/erc-2612.js Outdated Show resolved Hide resolved
test/solidity/oz/erc2771/forward.js Outdated Show resolved Hide resolved
test/solidity/oz/erc2771/forward.js Outdated Show resolved Hide resolved
test/solidity/oz/erc2771/forward.js Outdated Show resolved Hide resolved
test/solidity/oz/helpers/eip712.js Outdated Show resolved Hide resolved
@quiet-node
Copy link
Member

Tests are failing..

Nana-EC
Nana-EC previously approved these changes Dec 6, 2023
@Nana-EC
Copy link
Collaborator

Nana-EC commented Dec 6, 2023

@stefan-stefanooov please update PR description

@stefan-stefanooov stefan-stefanooov changed the title [OZ] ERC-2612 - Permit feat: [OZ] ERC-2612 - Permit Dec 6, 2023
Copy link
Member

@quiet-node quiet-node left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@stefan-stefanooov stefan-stefanooov merged commit f77a4ec into main Dec 8, 2023
23 of 24 checks passed
@stefan-stefanooov stefan-stefanooov deleted the 564-add-oz-erc2612-example branch December 8, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EVM evm related Limechain Items for Limechain team Tooling tooling
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add OZ ERC2612 example
3 participants