feat: implement ihrc in hts system contract mocks (#478) #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mo Shaikjee <[email protected]>
mshakeg
requested review from
AlfredoG87,
AleksandrinaAleksieva,
ebadiere,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0,
a team and
Nana-EC
as code owners
mshakeg
changed the title
mshakeg
changed the title
|
Hey @Nana-EC any idea why the PR Title Check still fails? |
Nana-EC
requested changes
Jan 12, 2024
Not sure. I left other blocking comments |
AlfredoG87
reviewed
Jan 12, 2024
Signed-off-by: Mo Shaikjee <[email protected]>
Signed-off-by: Mo Shaikjee <[email protected]>
|
Hey @Nana-EC can we get this merged? don't want to have to resolve any potential conflicts. |
Nana-EC
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR extends the
IHRCinterface solidity version support. Additionally, the HTS System Contract mock now implements theIHRCinterface.Related issue(s):
Fixes #598 and task 5 in #478
Notes for reviewer:
I'm not sure whether
IHRC(htsAddress).isAssociated(evmAddress)has yet been implemented, but I've added it here regardless.Checklist