feat: add workflow which allows to start tests against desired tag #649

georgi-l95 · 2024-01-29T19:19:59Z

Description:
This PR aims to add manual workflow, which can be triggered by specifying tag which the tests should run against.

Related issue(s):

Fixes #648

Notes for reviewer:

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

Signed-off-by: georgi-l95 <[email protected]>

github-actions · 2024-01-29T19:28:02Z

Test Results

242 tests ±0 236 ✔️ ±0 7m 42s ⏱️ +18s
  72 suites ±0     6 💤 ±0
  14 files ±0     0 ❌ ±0

Results for commit a4734bd. ± Comparison against base commit 8cabc7f.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.

should NOT be able to aggregate 150 calls to processLongInputTx ‑ Multicall Test Suite payable calls with large input should NOT be able to aggregate 150 calls to processLongInputTx

should NOT be able to aggregate 200 calls to processLongInputTx ‑ Multicall Test Suite payable calls with large input should NOT be able to aggregate 200 calls to processLongInputTx

♻️ This comment has been updated with latest results.

Signed-off-by: georgi-l95 <[email protected]>

Signed-off-by: Yaroslav Markovski <[email protected]>

Signed-off-by: georgi-l95 <[email protected]>

quiet-node · 2024-01-30T14:30:06Z

.github/workflows/test-workflow.yml

@@ -47,7 +50,7 @@ jobs:
          version: nightly

      - name: Start the local node
-        run: npx hedera start -d --network local
+        run: npx hedera start -d --network-tag=${{inputs.networkTag}} --mirror-tag=${{inputs.mirrorTag}} --relay-tag=${{inputs.relayTag}} --verbose=trace


Question: Above I saw the networkTag, mirrorTag, relayTag are marked required:false, does that mean if those tags are not entered, local node will pick up the latest tags?

yep, local node will start with local configuration(which is usually latest tags)

Nice work! Will be back for a full review soon

My idea with this manual workflow is to be triggered, when for example we have a new network tag. Instead of checking out repos locally, starting local-node and running tests, we can do it here with a simple click.

Nice initiative!

quiet-node · 2024-01-30T19:38:29Z

.github/workflows/manual-testing.yml

+      testfilter: PrngSystemContract
+      networkTag: ${{inputs.networkNodeTag}}
+      mirrorTag: ${{inputs.mirrorNodeTag}}
+      relayTag: ${{inputs.relayTag}}


Do you think we should make some room for the Solidity, Yul, and OZ contracts as well? https://github.com/hashgraph/hedera-smart-contracts/blob/main/.github/workflows/solidity-tests.yml

Might be too much for this case but not a bad idea.
@georgi-l95 have you tried the run out?
How long does everything take already and then when you add the above suggestions?

Yep, we can add them, they run in parallel, so it shouldn't run longer than now, which is as long as the slowest test (around 5 minutes)

Nana-EC

Nice addition.
A few questions

.github/workflows/manual-testing.yml

.github/workflows/test-workflow.yml

Nana-EC · 2024-01-31T04:03:12Z

.github/workflows/manual-testing.yml

+      testfilter: PrngSystemContract
+      networkTag: ${{inputs.networkNodeTag}}
+      mirrorTag: ${{inputs.mirrorNodeTag}}
+      relayTag: ${{inputs.relayTag}}


Might be too much for this case but not a bad idea.
@georgi-l95 have you tried the run out?
How long does everything take already and then when you add the above suggestions?

Signed-off-by: georgi-l95 <[email protected]>

georgi-l95 · 2024-01-31T21:34:51Z

test/multicall/Multicall.js

@@ -324,16 +324,16 @@ describe('Multicall Test Suite', function () {
      expect(receipt.status).to.eq(1);
    });

-    it('should NOT be able to aggregate 150 calls to processLongInputTx', async function () {
-      const n = 150;
+    it('should NOT be able to aggregate 200 calls to processLongInputTx', async function () {


this change is needed, because of this PR in the relay, which changes chunk size to around 50kb

Oh is that what it is? No wonder it kept failing in the ci

Signed-off-by: georgi-l95 <[email protected]>

quiet-node

LGTM. Thanks for the work!

quiet-node · 2024-01-31T22:14:20Z

test/multicall/Multicall.js

@@ -324,16 +324,16 @@ describe('Multicall Test Suite', function () {
      expect(receipt.status).to.eq(1);
    });

-    it('should NOT be able to aggregate 150 calls to processLongInputTx', async function () {
-      const n = 150;
+    it('should NOT be able to aggregate 200 calls to processLongInputTx', async function () {


Oh is that what it is? No wonder it kept failing in the ci

isavov

That's a great addition!

georgi-l95 added 2 commits January 29, 2024 20:50

feat: add new manual workflow

1214679

Signed-off-by: georgi-l95 <[email protected]>

feat: add workflow for manual testing

b1044cd

Signed-off-by: georgi-l95 <[email protected]>

georgi-l95 linked an issue Jan 29, 2024 that may be closed by this pull request

Add workflow which allows to start tests against desired tag #648

Closed

georgi-l95 self-assigned this Jan 29, 2024

georgi-l95 added the Limechain Items for Limechain team label Jan 29, 2024

chore: shorten run-nam

c9e58de

Signed-off-by: georgi-l95 <[email protected]>

georgi-l95 assigned yaroslav-007 Jan 30, 2024

feat: add permission section in Manual Testing

0cd5e57

Signed-off-by: Yaroslav Markovski <[email protected]>

yaroslav-007 force-pushed the 648-add-workflow-which-allows-to-start-tests-against-desired-tag branch from 68af2e9 to 0cd5e57 Compare January 30, 2024 14:16

georgi-l95 marked this pull request as ready for review January 30, 2024 14:21

georgi-l95 requested a review from a team as a code owner January 30, 2024 14:21

georgi-l95 requested review from quiet-node and isavov January 30, 2024 14:21

chore: update hedera local

40cc612

Signed-off-by: georgi-l95 <[email protected]>

quiet-node reviewed Jan 30, 2024

View reviewed changes

Nana-EC reviewed Jan 31, 2024

View reviewed changes

georgi-l95 requested review from AlfredoG87, AleksandrinaAleksieva, ebadiere, Ivo-Yankov, natanasow and yiliev0 as code owners January 31, 2024 21:30

fix: multicall test

d0d1ab2

Signed-off-by: georgi-l95 <[email protected]>

georgi-l95 force-pushed the 648-add-workflow-which-allows-to-start-tests-against-desired-tag branch from d148b17 to d0d1ab2 Compare January 31, 2024 21:33

georgi-l95 commented Jan 31, 2024

View reviewed changes

feat: add Solidity, OZ and YUL

a4734bd

Signed-off-by: georgi-l95 <[email protected]>

georgi-l95 force-pushed the 648-add-workflow-which-allows-to-start-tests-against-desired-tag branch from c9b0480 to a4734bd Compare January 31, 2024 21:51

quiet-node approved these changes Jan 31, 2024

View reviewed changes

isavov approved these changes Feb 1, 2024

View reviewed changes

Nana-EC approved these changes Feb 1, 2024

View reviewed changes

georgi-l95 merged commit 1be6eee into main Feb 2, 2024
23 checks passed

georgi-l95 deleted the 648-add-workflow-which-allows-to-start-tests-against-desired-tag branch February 2, 2024 08:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add workflow which allows to start tests against desired tag #649

feat: add workflow which allows to start tests against desired tag #649

georgi-l95 commented Jan 29, 2024 •

edited

Loading

github-actions bot commented Jan 29, 2024 •

edited

Loading

quiet-node Jan 30, 2024

georgi-l95 Jan 30, 2024

quiet-node Jan 30, 2024 •

edited

Loading

georgi-l95 Jan 30, 2024

quiet-node Jan 30, 2024

quiet-node Jan 30, 2024

Nana-EC Jan 31, 2024

georgi-l95 Jan 31, 2024

Nana-EC left a comment

Nana-EC Jan 31, 2024

georgi-l95 Jan 31, 2024

quiet-node Jan 31, 2024

quiet-node left a comment

quiet-node Jan 31, 2024

isavov left a comment

feat: add workflow which allows to start tests against desired tag #649

feat: add workflow which allows to start tests against desired tag #649

Conversation

georgi-l95 commented Jan 29, 2024 • edited Loading

github-actions bot commented Jan 29, 2024 • edited Loading

Test Results

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quiet-node Jan 30, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

quiet-node left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

isavov left a comment

Choose a reason for hiding this comment

georgi-l95 commented Jan 29, 2024 •

edited

Loading

github-actions bot commented Jan 29, 2024 •

edited

Loading

quiet-node Jan 30, 2024 •

edited

Loading