fix: removed ZeroHashes as private keys #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
Test Results 16 files + 4 76 suites +13 8m 16s ⏱️ +49s For more details on these failures, see this check. Results for commit a53d9a7. ± Comparison against base commit ed677b7. ♻️ This comment has been updated with latest results. |
ebadiere
reviewed
Feb 2, 2024
Signed-off-by: Logan Nguyen <[email protected]>
…nalized Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
requested review from
AlfredoG87,
AleksandrinaAleksieva,
georgi-l95,
Ivo-Yankov,
natanasow and
yiliev0
as code owners
ebadiere
approved these changes
Feb 2, 2024
ebadiere
deleted the
652-private-keys-as-zero-hashes-cause-private-key-is-invalid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
"Removed the ZeroHash instances as private keys within the
PRIVATE_KEYSconstant variable. It is not mandatory for thePRIVATE_KEYSconstant variable to contain exactly six private keys for the process to proceed. Attempting to fill the empty slots in thePRIVATE_KEYSvariable will result in aPrivate keys invaliderror."Related issue(s):
Fixes #652
Notes for reviewer:
Checklist