fix: simplified contract artifacts (#692) #693
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
changed the title
quiet-node
force-pushed
the
692-simplifying-contract-artifacts
branch
4 times, most recently
from
99c286c to
5abe6ce
Compare
… Contract DApp Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
692-simplifying-contract-artifacts
branch
from
5abe6ce to
9f34fe3
Compare
Nana-EC
requested changes
Mar 5, 2024
Nana-EC
requested review from
ebadiere,
acuarica,
natanasow and
AlfredoG87
and removed request for
david-bakin-sl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR streamlines contract artifacts by adopting ABI-only artifacts, replacing the default artifact files that include various attributes (_contractName, sourceName, abi, bytecode, deployedBytecode, linkReferences, deployedLinkReferences). Previously, all artifact files were committed to the repository, but now only ABI-only artifacts are included. Default artifacts continue to be generated post-compilation alongside ABI-only artifacts, but they are no longer committed to the repository.
Tasks done:
hardhat-abi-exporterplugin to generate ABI-only artifactshardhat-abi-exporterin thehardhat.config.jsfile to allow custom output path and run on every compilationRelated issue(s):
Fixes #692
Notes for reviewer:
Checklist