-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Slither tool analysis report #727
Adds Slither tool analysis report #727
Conversation
Signed-off-by: maciek.nabialek <[email protected]>
Hi @nabialek-arianelabs, thanks for the nice work! With a quick scan through the CI, I noticed that there are two tests failed. Please follow the conventional commits guidelines to update the title of the PR to fix the |
or [taint checking](https://en.wikipedia.org/wiki/Taint_checking). | ||
General Slither architecture is shown below on the fig. 1. | ||
|
||
 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the static/img.png has been removed? Should we keep the image to show here or should we remove this line?
}, | ||
... | ||
``` | ||
Full json output is available [here](Slither/slither-read-storage-mainnet.json) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is this Slither/slither-read-storage-mainnet.json file?
``` | ||
Execution of command: | ||
`slither-read-storage 0x00000000000000000000000000000000002e7a5d --json storage_layout.json --rpc-url https://mainnet.hashio.io/api` | ||
yields `ERROR:SlitherSolcParsing` with details available [here](slither_reports/slither-read-storage-hashscan-error.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Link embedded in here
won't work
#### Reports of the tests: | ||
| Smart contract | Result | | ||
|----------------------------------------------------------------------------------|--------------------------------------------------| | ||
| [AtomicHTS.sol](test_contracts/hts-precompile/AtomicHTS.sol) | [Report](slither_reports/AtomicHTS.md) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update these file paths
* Tests didn't generate any kind of high-impact vulnerability. The Table below depicts a detailed histogram | ||
of the reported issues by the Slither (for hts-precompile contracts): | ||
|
||
\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image is not found
function setBit(uint256 self, uint8 index) internal pure returns (uint256) { | ||
return self | (ONE << index); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing line at EOF
* Emits a {Transfer} event. | ||
*/ | ||
function transferFrom(address from, address to, uint256 value) external returns (bool); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing line at EOF
* @dev Returns the decimals places of the token. | ||
*/ | ||
function decimals() external view returns (uint8); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing line at EOF
} | ||
} | ||
|
||
//contract Attack { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is Attack commented out?
@@ -0,0 +1,42 @@ | |||
// SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update license to Apache-2.0
Replaced with: #740 |
Adds Slither tool analysis, docker files, and POC for ecrecover Slither detector.
Is dependant upon: https://github.com/hashgraph/hedera-smart-contracts/pull/726/files