feat: added support for release automation #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quiet-node
requested review from
AlfredoG87,
AleksandrinaAleksieva,
ebadiere,
georgi-l95,
Ivo-Yankov,
natanasow,
yiliev0 and
a team
as code owners
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
quiet-node
force-pushed
the
714-smart-contracts-release-automation
branch
from
0a6e11e to
b74ec69
Compare
rbarkerSL
requested changes
Jul 15, 2024
Signed-off-by: Logan Nguyen <[email protected]>
acuarica
reviewed
Jul 15, 2024
| run: npm ci | ||
|
|
||
| - name: Bump Versions | ||
| run: npm run bump-version --semver=${{ env.NEXT_VERSION_SNAPSHOT }} --snapshot=true |
There was a problem hiding this comment.
Is it snapshot=true being used? Otherwise should we remove it?
Suggested change
| run: npm run bump-version --semver=${{ env.NEXT_VERSION_SNAPSHOT }} --snapshot=true | |
| run: npm run bump-version --semver=${{ env.NEXT_VERSION_SNAPSHOT }} |
| run: npm ci | ||
|
|
||
| - name: Bump Versions | ||
| run: npm run bump-version --semver=${{ env.NEXT_VERSION_SNAPSHOT }} --snapshot=true |
There was a problem hiding this comment.
In case snapshot=true is not used (see other comment), should we also replace the bump-version script with npm version. AFAIS they both have the same effect, updating both package.json and package-lock.json.
Suggested change
| run: npm run bump-version --semver=${{ env.NEXT_VERSION_SNAPSHOT }} --snapshot=true | |
| run: npm version ${{ env.NEXT_VERSION_SNAPSHOT }} |
There was a problem hiding this comment.
Pushed in the new update.
This reverts commit f18a358. Signed-off-by: Logan Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #714