Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fork storage layout description #902

Closed
wants to merge 1 commit into from
Closed

feat: fork storage layout description #902

wants to merge 1 commit into from

Conversation

arianejasuwienas
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@arianejasuwienas
feat: fork storage layout description
342ba1f 
Signed-off-by: Mariusz Jasuwienas <[email protected]>
@github-actions GitHub Actions
Copy link

Test Results

  16 files    77 suites   7m 5s ⏱️
243 tests 236 ✔️ 1 💤 6 ❌
263 runs  255 ✔️ 2 💤 6 ❌

For more details on these failures, see this check.

Results for commit 342ba1f.

@acuarica
Copy link
Contributor

Looking good.

  • Please move this file to forking/README.md so we have a place to include all design decisions related to forking.
  • Please include in the Storage Layout section some examples on how the layout will look like. Include primitive types, strings and mappings.

@acuarica
Copy link
Contributor

Closing this because we have included this analysis in the hedera-forking repo in PR

@acuarica acuarica closed this Sep 10, 2024
@acuarica acuarica deleted the fork-storage-layout-description branch September 10, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arianejasuwienas @acuarica