-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new tests for HIP-1010 #911
feat: add new tests for HIP-1010 #911
Conversation
Test Results 16 files + 1 82 suites +10 12m 8s ⏱️ + 7m 30s Results for commit c1a509b. ± Comparison against base commit 40d2824. This pull request removes 3 and adds 84 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Blocked by hashgraph/hedera-mirror-node#9136 |
This issue was resolved, however currently waiting for a new release of the local node that will use newest mirror node tag 0.113.1 |
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
f39602c
to
b2326fc
Compare
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
Signed-off-by: Konstantina Blazhukova <[email protected]>
17b41a9
to
c1a509b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some nits/questions 🚀
@@ -395,6 +494,64 @@ class Utils { | |||
return tokenAddress; | |||
} | |||
|
|||
static hexToASCII(str) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a similar method defined here https://github.com/hashgraph/hedera-smart-contracts/blob/main/test/precompile/hedera-token-service/redirect-for-token.js#L40. We may consider extracting these methods in utils class?
@@ -577,6 +745,18 @@ class Utils { | |||
} | |||
} | |||
|
|||
static async getAccountBalance(address) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's for test purposes only, but we can use the mirror node for balance querying, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natanasow yes, we can
Description:
Testing new functionality regarding fees, namely updateFungibleTokenCustomFeesPublic and updateNonFungibleTokenCustomFeesPublic (HIP-1010), but ALSO testing if fees are correctly deducted from accounts, since there were no such test before. Thus, the tests in this PR are slightly bigger and more complex than expected
Related issue(s):
Fixes #876