Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): installed js-cookie #926

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

quiet-node
Copy link
Member

Description:
For some reason, the js-cookie module is not listed in the root dependencies, but the next build command does not detect the missing package. This PR added the js-cookie to the package.

Related issue(s):

Fixes #925

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Logan Nguyen <[email protected]>
@quiet-node quiet-node requested a review from a team as a code owner August 31, 2024 22:42
@quiet-node quiet-node self-assigned this Aug 31, 2024
@quiet-node quiet-node added the dependencies Pull requests that update a dependency file label Aug 31, 2024
@quiet-node quiet-node added this to the 0.10.0 milestone Aug 31, 2024
Copy link

github-actions bot commented Aug 31, 2024

Test Results

  16 files  ±0    77 suites  ±0   7m 6s ⏱️ -8s
254 tests ±0  247 ✔️ ±0  7 💤 ±0  0 ±0 
263 runs  ±0  255 ✔️ ±0  8 💤 ±0  0 ±0 

Results for commit f0c95d9. ± Comparison against base commit 3811212.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

@quiet-node quiet-node merged commit 6625453 into main Sep 18, 2024
36 checks passed
@quiet-node quiet-node deleted the 925-dapp-playground-cannot-find-js-cookie-module branch September 18, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DApp Playground cannot find js-cookie module
2 participants