Skip to content

fix: modified isErc for better performance in ERC Registry tool (#1… #483

fix: modified isErc for better performance in ERC Registry tool (#1…

fix: modified isErc for better performance in ERC Registry tool (#1… #483

GitHub Actions / Unit Tests results succeeded Dec 19, 2024 in 0s

All 21 tests pass, 2 skipped in 38s

23 tests   - 33   21 ✅  - 34   38s ⏱️ - 5m 58s
 9 suites ± 0    2 💤 + 2 
 1 files   ± 0    0 ❌  -  1 

Results for commit f9dbe60. ± Comparison against earlier commit 4b834fd.

Annotations

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Unit Tests results

2 skipped tests found

There are 2 skipped tests, see "Raw output" for the full list of skipped tests.
Raw output
should deposit, buy and sell tokens from ExchangeV1 ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should deposit, buy and sell tokens from ExchangeV1
should deposit, buy and withdraw tokens from ExchangeV2 ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should deposit, buy and withdraw tokens from ExchangeV2

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Unit Tests results

23 tests found

There are 23 tests, see "Raw output" for the full list of tests.
Raw output
Should NOT be able to change the current proxy admin if the caller is not an admin ‑ @OZERC1967Upgrade Upgradable Vote Test Suite Proxy Contract tests Should NOT be able to change the current proxy admin if the caller is not an admin
Should be able to change the current proxy admin to a new address ‑ @OZERC1967Upgrade Upgradable Vote Test Suite Proxy Contract tests Should be able to change the current proxy admin to a new address
Should be able to get the predefined ERC1967 ADMIN_SLOT ‑ @OZERC1967Upgrade Upgradable Vote Test Suite Proxy Contract tests Should be able to get the predefined ERC1967 ADMIN_SLOT
Should be able to get the predefined ERC1967 IMPLEMENTATION_SLOT ‑ @OZERC1967Upgrade Upgradable Vote Test Suite Proxy Contract tests Should be able to get the predefined ERC1967 IMPLEMENTATION_SLOT
Should deploy vote proxy contract with a new proxy admin ‑ @OZERC1967Upgrade Upgradable Vote Test Suite Proxy Contract tests Should deploy vote proxy contract with a new proxy admin
Should deploy vote proxy contract with the with voteV1 being the current logic contract ‑ @OZERC1967Upgrade Upgradable Vote Test Suite Proxy Contract tests Should deploy vote proxy contract with the with voteV1 being the current logic contract
Should upgrade proxy vote to point to voteV2 ‑ @OZERC1967Upgrade Upgradable Vote Test Suite Proxy Contract tests Should upgrade proxy vote to point to voteV2
should be able to increase and decrease counter on V1 ‑ Proxy Upgrade Contracts Test Suite Counter Upgradable Contract Test Suite should be able to increase and decrease counter on V1
should be able to increase and decrease counter on V2 ‑ Proxy Upgrade Contracts Test Suite Counter Upgradable Contract Test Suite should be able to increase and decrease counter on V2
should be able to upgrade contract to V2 ‑ Proxy Upgrade Contracts Test Suite Counter Upgradable Contract Test Suite should be able to upgrade contract to V2
should deposit, buy and sell tokens from ExchangeV1 ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should deposit, buy and sell tokens from ExchangeV1
should deposit, buy and withdraw tokens from ExchangeV2 ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should deposit, buy and withdraw tokens from ExchangeV2
should not be able to change name ‑ Proxy Upgrade Contracts Test Suite Counter Upgradable Contract Test Suite should not be able to change name
should not be able to get version ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should not be able to get version
should upgrade contract to V2 ‑ Proxy Upgrade Contracts Test Suite DEX Upgradable Contract Test Suite should upgrade contract to V2
should verify it calls the correct contract and method via proxy ‑ @OZTransparentUpgradeableProxy Test Suite should verify it calls the correct contract and method via proxy
should verify it can change the underlying contract ‑ @OZTransparentUpgradeableProxy Test Suite should verify it can change the underlying contract
should verify proxy admin cannot be called by anyone other than owner ‑ @OZTransparentUpgradeableProxy Test Suite should verify proxy admin cannot be called by anyone other than owner
verifies contract can be called via beacon proxy ‑ @OZBeaconProxy Test Suite verifies contract can be called via beacon proxy
verifies several proxies can be created and used ‑ @OZBeaconProxy Test Suite verifies several proxies can be created and used
verifies underlying contract can be changed only by owner ‑ @OZBeaconProxy Test Suite logicContractV2 verifies underlying contract can be changed only by owner
verifies underlying contract can be changed ‑ @OZBeaconProxy Test Suite verifies underlying contract can be changed
verifies underlying contract cannot be changed to EOA address ‑ @OZBeaconProxy Test Suite logicContractV2 verifies underlying contract cannot be changed to EOA address