fix: 175 CompareTo Generation fails if fields include underscores #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsync-swirlds
requested review from
imalygin,
artemananiev and
anthony-swirldslabs
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
anthony-swirldslabs
previously approved these changes
Jan 19, 2024
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/PbjCompilerTask.java
Outdated
Show resolved
Hide resolved
pbj-core/pbj-compiler/src/main/java/com/hedera/pbj/compiler/PbjCompilerTask.java
Outdated
Show resolved
Hide resolved
* Adjusted ModelGenerator to use field `name` instead of `nameCamelFirstLower` when filtering comparable fields. * Added an abbreviated stack trace for exceptions when compiling proto files, to help debug future issues like this. * Modified comparable.proto in integration tests, renaming `bytes bytes` to `bytes test_bytes` to prevent regression. * Modified the spotless conventions to allow Java 21 to be used Signed-off-by: Joseph Sinclair <[email protected]>
jsync-swirlds
force-pushed
the
00175-fix-CompareTo-Generation
branch
from
2b62291 to
e1c8156
Compare
anthony-swirldslabs
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nameinstead ofnameCamelFirstLowerwhen filtering comparable fields.bytes bytestobytes test_bytesto prevent regression.Fixes: #175