Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture the full command line call, not just the command and subcommand, but all flags and their parameters as it was called #960

Closed
Tracked by #591
jeromy-cannon opened this issue Dec 9, 2024 · 0 comments · Fixed by #1208
Assignees
Labels
P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.

Comments

@jeromy-cannon
Copy link
Contributor

jeromy-cannon commented Dec 9, 2024

currently in the remote config history, it only tracks down to the sub command. We want to track the full argv. However, we want to provide a mask **** for certain private/sensitive values such as private keys or local directories.

Update the CommandFlag interface to add an optional dataMask: string property. In flags.ts set the dataMask property to *** for the following flags:

  • operatorKey
  • privateKey
  • gossipPrivateKey
  • tlsPrivateKey
  • ed25519PrivateKey
  • ecdsaPrivateKey
  • adminKey
  • grpcTlsKeyPath
  • grpcWebTlsKeyPath
  • storageAccessKey
  • storageSecrets
  • storageEndpoint
  • storageBucket
  • backupBucket
  • googleCredential

related issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
None yet
2 participants