Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remote-config): instead of keeping just the command and the subcommand inside the remote config keep the flags as passed #1208

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Jan 24, 2025

Description

  • add new function to strigify the flags from the argv and to store it together with the command and subcommand inside the remote config's commandHistory: string[]
# Example of new structure
commandHistory:                                                                                              
  - cluster setup
  - network deploy --node-aliases node1,node2 --namespace solo-e2e
  • rename the flag.nodeAliasesUnparsed cli name from node-aliases-unparsed --> node-aliases

Related Issues

…lag.nodeAliasesUnparsed cli name from node-aliases-unparsed --> node-aliases

Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   3s ⏱️ ±0s
236 tests +3  236 ✅ +3  0 💤 ±0  0 ❌ ±0 
241 runs  +3  241 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 21d0ba1. ± Comparison against base commit 64fbf95.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 24, 2025

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   14s ⏱️ ±0s
236 tests +3  236 ✅ +3  0 💤 ±0  0 ❌ ±0 
241 runs  +3  241 ✅ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 21d0ba1. ± Comparison against base commit 64fbf95.

♻️ This comment has been updated with latest results.

@instamenta instamenta requested a review from a team as a code owner January 24, 2025 13:52
Copy link
Contributor

E2E Test Report

 17 files  126 suites   1h 28m 2s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs  269 ✅ 0 💤 0 ❌

Results for commit a49befd.

1 similar comment
Copy link
Contributor

E2E Test Report

 17 files  126 suites   1h 28m 2s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs  269 ✅ 0 💤 0 ❌

Results for commit a49befd.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 64fbf951 12.12%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (64fbf95) Report Missing Report Missing Report Missing
Head commit (a49befd) 21794 18235 83.67%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1208) 33 4 12.12%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 12.12121% with 29 lines in your changes missing coverage. Please review.

Project coverage is 82.80%. Comparing base (9d1a8cb) to head (a49befd).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/core/config/remote/remote_config_manager.ts 9.37% 29 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1208      +/-   ##
==========================================
- Coverage   82.89%   82.80%   -0.10%     
==========================================
  Files          78       78              
  Lines       21763    21794      +31     
  Branches     1383     1389       +6     
==========================================
+ Hits        18040    18046       +6     
+ Misses       3696     3687       -9     
- Partials       27       61      +34     
Files with missing lines Coverage Δ
src/commands/flags.ts 75.65% <100.00%> (ø)
src/core/config/remote/remote_config_manager.ts 70.60% <9.37%> (-5.68%) ⬇️

... and 15 files with indirect coverage changes

Impacted file tree graph

…gs that are considered sensitive

Signed-off-by: instamenta <[email protected]>
…well as the functionality to display flags with datamask if specified

Signed-off-by: instamenta <[email protected]>
@jeromy-cannon jeromy-cannon added PR: Needs Approval A pull request that needs reviews and approvals. PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. and removed PR: Needs Approval A pull request that needs reviews and approvals. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved.
Projects
None yet
2 participants