Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should run npm install before build #1117

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Jan 6, 2025

Description

This pull request changes the following:

  • should run npm install before build

Related Issues

Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   4s ⏱️ -1s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 70ed668. ± Comparison against base commit a3231f9.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   15s ⏱️ +3s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 70ed668. ± Comparison against base commit a3231f9.

@JeffreyDallas JeffreyDallas self-assigned this Jan 6, 2025
Copy link
Contributor

github-actions bot commented Jan 6, 2025

E2E Test Report

 16 files  ±0  121 suites  ±0   1h 19m 4s ⏱️ - 1m 42s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
261 runs  ±0  261 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 70ed668. ± Comparison against base commit a3231f9.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

E2E Test Report

 16 files  ±0  121 suites  ±0   1h 19m 4s ⏱️ - 1m 42s
258 tests ±0  258 ✅ ±0  0 💤 ±0  0 ❌ ±0 
261 runs  ±0  261 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 70ed668. ± Comparison against base commit a3231f9.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.02% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a3231f9) 20011 17110 85.50%
Head commit (70ed668) 20038 (+27) 17137 (+27) 85.52% (+0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1117) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link
Contributor

@mishomihov00 mishomihov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review applies to .github/workflows/flow-task-test.yaml

@jeromy-cannon jeromy-cannon merged commit 3398875 into main Jan 7, 2025
43 of 44 checks passed
@jeromy-cannon jeromy-cannon deleted the 01116-D-Task-steps branch January 7, 2025 14:03
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.67%. Comparing base (a3231f9) to head (70ed668).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #1117    +/-   ##
========================================
  Coverage   84.67%   84.67%            
========================================
  Files          76       76            
  Lines       20038    20038            
  Branches     1842     1239   -603     
========================================
  Hits        16967    16967            
- Misses       2922     3031   +109     
+ Partials      149       40   -109     

see 31 files with indirect coverage changes

Impacted file tree graph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Taskfile calls tsc before npm install
3 participants