feat: update genesis-network.json to add roster entries and more #1122

jeromy-cannon · 2025-01-07T14:29:48Z

Description

This pull request changes the following:

update genesis-network.json to add roster entries
updated prettier to set print width to 120
pass the node ID to the solo-chart to set the labels and env vars
update genesis-network.json to use node IDs from network consensus pods
fixed Templates.nodeIdFromNodeAlias(config.nodeAlias) - 1 issue
fixed taskfile issue for removing files that might belong to another user
added debug node alias setting to taskfile
added solo charts dir setting to taskfile
fixed taskfile issue that cause solo npm install multiple times and to the wrong directory if ran from repo root directory
added --load-balancer enabled flag to solo network deploy because solo-charts now defaults to ClusterIP
moved genesis network json creation and copying into solo node setup
added more sleep time for when debug is enabled to give time to debug
added node ID and namespace to NetworkNodeServiceBuilder
bumped solo-chart to v0.41.0
disabled addressBook.useRosterLifecycle=true as the genesis-network.json pathway does not work when the network comes back up after being stopped due to invalid signature errors

Related Issues

github-actions · 2025-01-07T14:31:26Z

Unit Test Results - Linux

1 files ±0 58 suites ±0 3s ⏱️ ±0s
227 tests ±0 227 ✅ ±0 0 💤 ±0 0 ❌ ±0
232 runs ±0 232 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 3116354. ± Comparison against base commit 808516c.

♻️ This comment has been updated with latest results.

github-actions · 2025-01-07T14:32:24Z

Unit Test Results - Windows

1 files ±0 58 suites ±0 13s ⏱️ -2s
227 tests ±0 227 ✅ ±0 0 💤 ±0 0 ❌ ±0
232 runs ±0 232 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit 3116354. ± Comparison against base commit 808516c.

♻️ This comment has been updated with latest results.

commit 2207cd4 Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 20:48:04 2025 +0000 fixed issue where key wasn't populated Signed-off-by: Jeromy Cannon <[email protected]> commit 754ac73 Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 20:26:41 2025 +0000 refactored to extract methods for TODO Signed-off-by: Jeromy Cannon <[email protected]> commit 214fe28 Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 20:19:25 2025 +0000 moved generate network json to node setup, updated nodeId to do the -1 inside the template function, add nodeid into network service map Signed-off-by: Jeromy Cannon <[email protected]> commit 0766b0f Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 18:06:41 2025 +0000 make user specific temp files in case of multi-user machine Signed-off-by: Jeromy Cannon <[email protected]> commit aac9ba6 Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 18:00:24 2025 +0000 don't fail task if rm command fails Signed-off-by: Jeromy Cannon <[email protected]> commit 26a907e Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 17:57:28 2025 +0000 only run solo install once Signed-off-by: Jeromy Cannon <[email protected]> commit 28917ca Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 17:57:00 2025 +0000 set prettierrc print width to 120 Signed-off-by: Jeromy Cannon <[email protected]> commit d1c7876 Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 14:27:34 2025 +0000 Squashed commit of the following: commit 3754a27 Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 13:01:53 2025 +0000 fixed sleep bug with debugger flag Signed-off-by: Jeromy Cannon <[email protected]> commit 9dcbf12 Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 13:01:38 2025 +0000 add charts dir Signed-off-by: Jeromy Cannon <[email protected]> commit 2aa4a14 Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 13:01:15 2025 +0000 reverted with fixes Signed-off-by: Jeromy Cannon <[email protected]> commit 98e747d Author: Jeromy Cannon <[email protected]> Date: Tue Jan 7 13:01:05 2025 +0000 add node-id to yml files Signed-off-by: Jeromy Cannon <[email protected]> commit 268e106 Author: Jeromy Cannon <[email protected]> Date: Mon Jan 6 14:19:48 2025 +0000 remove unused imports Signed-off-by: Jeromy Cannon <[email protected]> commit 93da63a Author: Jeromy Cannon <[email protected]> Date: Fri Jan 3 22:58:39 2025 +0000 update tasks to handle debugger, also updated code for genesis-network.json Signed-off-by: Jeromy Cannon <[email protected]> commit c604fd7 Author: Jeromy Cannon <[email protected]> Date: Fri Jan 3 14:44:04 2025 +0000 changes load, but nodes don't start due to incorrect signature Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

…, and disable addressBook.useRosterLifecycle=true Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

…s ready Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

…the node-name to the services Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>

github-actions · 2025-01-09T06:46:21Z

E2E Test Report

16 files 121 suites 1h 21m 59s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs 261 ✅ 0 💤 0 ❌

Results for commit 3116354.

github-actions · 2025-01-09T06:46:21Z

E2E Test Report

16 files 121 suites 1h 21m 59s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs 261 ✅ 0 💤 0 ❌

Results for commit 3116354.

codacy-production · 2025-01-09T06:46:37Z

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for `808516c`¹	✅ 60.55%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (`808516c`)	Report Missing	Report Missing	Report Missing
Head commit (`3116354`)	20633	17418	84.42%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#1122)	327	198	60.55%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

codecov · 2025-01-09T06:48:20Z

Codecov Report

Attention: Patch coverage is 60.24465% with 130 lines in your changes missing coverage. Please review.

Project coverage is 83.64%. Comparing base (1cd0e28) to head (3116354).
Report is 43 commits behind head on main.

Files with missing lines	Patch %	Lines
...network_models/genesis_network_data_constructor.ts	10.20%	44 Missing ⚠️
src/commands/node/tasks.ts	61.33%	29 Missing ⚠️
...sis_network_models/genesis_network_data_wrapper.ts	58.82%	14 Missing ⚠️
...etwork_models/genesis_network_node_data_wrapper.ts	23.52%	13 Missing ⚠️
...odels/genesis_network_roster_entry_data_wrapper.ts	75.67%	9 Missing ⚠️
src/commands/network.ts	46.66%	8 Missing ⚠️
src/core/account_manager.ts	75.00%	6 Missing ⚠️
src/core/key_manager.ts	76.92%	3 Missing ⚠️
src/core/platform_installer.ts	84.21%	3 Missing ⚠️
src/core/helpers.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
- Coverage   84.66%   83.64%   -1.02%     
==========================================
  Files          75       77       +2     
  Lines       20302    20633     +331     
  Branches     1929     1399     -530     
==========================================
+ Hits        17188    17258      +70     
- Misses       2957     3329     +372     
+ Partials      157       46     -111

Files with missing lines	Coverage Δ
src/commands/flags.ts	`74.77% <100.00%> (+0.16%)`	⬆️
src/commands/node/handlers.ts	`90.73% <100.00%> (+0.01%)`	⬆️
src/core/k8.ts	`85.42% <100.00%> (-2.41%)`	⬇️
src/core/network_node_services.ts	`100.00% <100.00%> (ø)`
src/core/profile_manager.ts	`97.16% <100.00%> (-0.17%)`	⬇️
src/core/templates.ts	`72.34% <100.00%> (-0.71%)`	⬇️
version.ts	`100.00% <100.00%> (ø)`
src/core/helpers.ts	`81.86% <0.00%> (ø)`
src/core/key_manager.ts	`91.23% <76.92%> (+1.98%)`	⬆️
src/core/platform_installer.ts	`88.08% <84.21%> (-0.25%)`	⬇️
... and 7 more

... and 24 files with indirect coverage changes

## [0.33.0](v0.32.0...v0.33.0) (2025-01-13) ### Features * add support for genesis throttle configuration ([#1026](#1026)) ([d8903a8](d8903a8)) * enable Blockstreams and uploader ([#1109](#1109)) ([ed6527b](ed6527b)) * inspect existing cluster resources during cluster setup ([#1094](#1094)) ([808516c](808516c)) * production readiness pass custom mirror node postgresql credentials and server address ([#1128](#1128)) ([f8b7e41](f8b7e41)) * support using GCS for backup uploader ([#1130](#1130)) ([5fe2f4e](5fe2f4e)) * update genesis-network.json to add roster entries and more ([#1122](#1122)) ([c27d1d6](c27d1d6)) * Updating solo to leverage changes after moving acme-cluster-issuer and haproxy-ingress out of mirror-node-explorer ([#1079](#1079)) ([7965894](7965894)) * use gcs for stream file storage ([#994](#994)) ([04d5806](04d5806)) ### Bug Fixes * add missing images, fix debug page images ([#1092](#1092)) ([4073d31](4073d31)) * Bug when running `solo cluster connect` after fresh install ([#1123](#1123)) ([1cd0e28](1cd0e28)) * bump solo-charts to 0.42.2 to pull in blockStreams fix ([#1138](#1138)) ([c482895](c482895)) * bump versions of hedera, json rpc relay, and mirror node ([#1147](#1147)) ([0784b46](0784b46)) * clarify how to use nvm ([#1125](#1125)) ([bdc1873](bdc1873)) * commit message of auto update ([#1106](#1106)) ([a3231f9](a3231f9)) * external link rendering ([#1118](#1118)) ([28af1fe](28af1fe)) * file size empty error when throttle file is provided on command line ([#1140](#1140)) ([5180a76](5180a76)) * fixed release artifact version issue and updated readme link ([#1090](#1090)) ([84e6611](84e6611)) * **lease:** reworks the previous fix addressing renewal issues ([#1105](#1105)) ([5edb9c9](5edb9c9)) * should run `npm install` before build ([#1117](#1117)) ([3398875](3398875)) * solo deployment create should use email address in local config if it is already there instead of prompting the user for it ([#1112](#1112)) ([362df60](362df60)) * started adding a yachli example and taskfile ([#1132](#1132)) ([8753723](8753723)) * update to AccountManager._getNodeClient() to parallel node connection setup ([#1091](#1091)) ([4959a12](4959a12))

swirlds-automation · 2025-01-13T21:31:22Z

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation · 2025-01-21T02:02:21Z

🎉 This PR is included in version 0.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jeromy-cannon self-assigned this Jan 7, 2025

jeromy-cannon force-pushed the 01031-genesis-network-roster-entries branch 2 times, most recently from 6ba5f58 to afe3119 Compare January 7, 2025 20:51

jeromy-cannon changed the title ~~feat: update genesis-network.json to add roster entries~~ feat: update genesis-network.json to add roster entries and more Jan 7, 2025

jeromy-cannon force-pushed the 01031-genesis-network-roster-entries branch from 0dd79b2 to 88bb6ed Compare January 7, 2025 22:25

jeromy-cannon added 12 commits January 8, 2025 21:42

bump solo-charts version to 0.41.0

679f666

Signed-off-by: Jeromy Cannon <[email protected]>

only create/copy the genesis-network.json when it is actually genesis…

157cc47

…, and disable addressBook.useRosterLifecycle=true Signed-off-by: Jeromy Cannon <[email protected]>

disable genesis network json creation and upload

ba05502

Signed-off-by: Jeromy Cannon <[email protected]>

added todo for application.properties for when genesis-network.json i…

f97ee9a

…s ready Signed-off-by: Jeromy Cannon <[email protected]>

fixed bugs preventing test cases from passing

45e01d2

Signed-off-by: Jeromy Cannon <[email protected]>

need to add label 'solo.hedera.com/type=network-node', since I added …

948be42

…the node-name to the services Signed-off-by: Jeromy Cannon <[email protected]>

revert commented out code

66490c4

Signed-off-by: Jeromy Cannon <[email protected]>

fix node delete e2e test case

a4b974c

Signed-off-by: Jeromy Cannon <[email protected]>

fix node update issue

81c8c0b

Signed-off-by: Jeromy Cannon <[email protected]>

return node client in refresh node client

9c217d4

Signed-off-by: Jeromy Cannon <[email protected]>

fix node update test

9fb1fc9

Signed-off-by: Jeromy Cannon <[email protected]>

jeromy-cannon force-pushed the 01031-genesis-network-roster-entries branch from cf62ae0 to 9fb1fc9 Compare January 8, 2025 21:42

jeromy-cannon marked this pull request as ready for review January 8, 2025 22:28

jeromy-cannon requested review from leninmehedy and a team as code owners January 8, 2025 22:28

jeromy-cannon requested review from Ivo-Yankov, nathanklick, JeffreyDallas and instamenta January 8, 2025 22:29

fixed missing skip node in separate node delete test

3116354

Signed-off-by: Jeromy Cannon <[email protected]>

instamenta approved these changes Jan 9, 2025

View reviewed changes

jeromy-cannon merged commit c27d1d6 into main Jan 9, 2025
39 of 42 checks passed

jeromy-cannon deleted the 01031-genesis-network-roster-entries branch January 9, 2025 09:06

swirlds-automation added the released label Jan 13, 2025

swirlds-automation added the released on @0.33.x label Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update genesis-network.json to add roster entries and more #1122

feat: update genesis-network.json to add roster entries and more #1122

jeromy-cannon commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 9, 2025

github-actions bot commented Jan 9, 2025

codacy-production bot commented Jan 9, 2025

codecov bot commented Jan 9, 2025 •

edited

Loading

swirlds-automation commented Jan 13, 2025

swirlds-automation commented Jan 21, 2025

feat: update genesis-network.json to add roster entries and more #1122

feat: update genesis-network.json to add roster entries and more #1122

Conversation

jeromy-cannon commented Jan 7, 2025 • edited Loading

Description

Related Issues

github-actions bot commented Jan 7, 2025 • edited Loading

Unit Test Results - Linux

github-actions bot commented Jan 7, 2025 • edited Loading

Unit Test Results - Windows

github-actions bot commented Jan 9, 2025

E2E Test Report

github-actions bot commented Jan 9, 2025

E2E Test Report

codacy-production bot commented Jan 9, 2025

Coverage summary from Codacy

See diff coverage on Codacy

See your quality gate settings Change summary preferences

Footnotes

codecov bot commented Jan 9, 2025 • edited Loading

Codecov Report

swirlds-automation commented Jan 13, 2025

swirlds-automation commented Jan 21, 2025

jeromy-cannon commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

github-actions bot commented Jan 7, 2025 •

edited

Loading

codecov bot commented Jan 9, 2025 •

edited

Loading