Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bug when running solo cluster connect after fresh install #1123

Conversation

Ivo-Yankov
Copy link
Contributor

@Ivo-Yankov Ivo-Yankov commented Jan 7, 2025

Description

Adds a new task to solo cluster connect for creating all home directories in case any of them are missing.

Related Issues

@Ivo-Yankov Ivo-Yankov changed the title fix: Bug when running solo cluster connect with a new installation fix: Bug when running solo cluster connect after fresh install Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Unit Test Results - Linux

  1 files  ±0   58 suites  ±0   3s ⏱️ -1s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4bbc4f7. ± Comparison against base commit 5b9d937.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Unit Test Results - Windows

  1 files  ±0   58 suites  ±0   13s ⏱️ -1s
227 tests ±0  227 ✅ ±0  0 💤 ±0  0 ❌ ±0 
232 runs  ±0  232 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 4bbc4f7. ± Comparison against base commit 5b9d937.

@Ivo-Yankov Ivo-Yankov marked this pull request as ready for review January 7, 2025 14:41
@Ivo-Yankov Ivo-Yankov requested review from leninmehedy and a team as code owners January 7, 2025 14:41
@Ivo-Yankov Ivo-Yankov self-assigned this Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

E2E Test Report

 16 files  121 suites   1h 19m 30s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
261 runs  261 ✅ 0 💤 0 ❌

Results for commit 4bbc4f7.

♻️ This comment has been updated with latest results.

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 73.68%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (362df60) 20016 17184 85.85%
Head commit (4bbc4f7) 20052 (+36) 17221 (+37) 85.88% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1123) 38 28 73.68%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 10 lines in your changes missing coverage. Please review.

Project coverage is 85.04%. Comparing base (362df60) to head (4bbc4f7).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/base.ts 83.87% 5 Missing ⚠️
src/commands/cluster/tasks.ts 33.33% 4 Missing ⚠️
src/commands/cluster/handlers.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
+ Coverage   85.03%   85.04%   +0.01%     
==========================================
  Files          75       75              
  Lines       20043    20052       +9     
  Branches     1333     1241      -92     
==========================================
+ Hits        17044    17054      +10     
- Misses       2946     2980      +34     
+ Partials       53       18      -35     
Files with missing lines Coverage Δ
src/commands/init.ts 87.74% <ø> (+1.87%) ⬆️
src/commands/cluster/handlers.ts 85.13% <0.00%> (-0.58%) ⬇️
src/commands/cluster/tasks.ts 92.94% <33.33%> (-1.08%) ⬇️
src/commands/base.ts 95.66% <83.87%> (-1.65%) ⬇️

... and 13 files with indirect coverage changes

Impacted file tree graph

@jeromy-cannon jeromy-cannon merged commit 1cd0e28 into main Jan 7, 2025
42 of 45 checks passed
@jeromy-cannon jeromy-cannon deleted the 01121-bug-solo-cluster-connect-n-solo-e2e-throws-local-configyml-not-found-error branch January 7, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: solo cluster connect -n solo-e2e throws local-config.yml not found error
2 participants