Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: solo deployment create should use the context and cluster provided for where to save the remote config #1142

Merged

fix logic

4282698
Select commit
Loading
Failed to load commit list.
Merged

feat: solo deployment create should use the context and cluster provided for where to save the remote config #1142

fix logic
4282698
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 1s

82.94% (+0.03%) compared to ab018a7

View this Pull Request on Codecov

82.94% (+0.03%) compared to ab018a7

Details

Codecov Report

Attention: Patch coverage is 90.99099% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.94%. Comparing base (ab018a7) to head (4282698).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/config/local_config.ts 0.00% 7 Missing ⚠️
src/commands/cluster/handlers.ts 0.00% 2 Missing ⚠️
src/core/k8.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   82.91%   82.94%   +0.03%     
==========================================
  Files          77       77              
  Lines       21335    21366      +31     
  Branches     1808     1455     -353     
==========================================
+ Hits        17690    17723      +33     
- Misses       3559     3608      +49     
+ Partials       86       35      -51     
Files with missing lines Coverage Δ
src/commands/cluster/configs.ts 84.55% <100.00%> (+1.35%) ⬆️
src/commands/cluster/tasks.ts 88.80% <100.00%> (+0.34%) ⬆️
src/core/k8.ts 85.27% <0.00%> (+0.40%) ⬆️
src/commands/cluster/handlers.ts 84.56% <0.00%> (ø)
src/core/config/local_config.ts 65.72% <0.00%> (-1.36%) ⬇️

... and 23 files with indirect coverage changes

Impacted file tree graph