Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remote-config): save reusable solo flags in remoteconfig #1191

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

instamenta
Copy link
Contributor

@instamenta instamenta commented Jan 21, 2025

Description

adds new class CommonFlagsDataWrapper to handle keeping the state of the flags inside the remote config, it's added to the middleware which loads and and it will populate the flags if needed.

Related Issues

…mote config common flags data wrapper and fix failing tests

Signed-off-by: instamenta <[email protected]>
…re type imports because they are impossible to fix in the context of the remote config

Signed-off-by: instamenta <[email protected]>
@instamenta instamenta self-assigned this Jan 21, 2025
@instamenta instamenta requested review from leninmehedy and a team as code owners January 21, 2025 14:03
@instamenta instamenta linked an issue Jan 21, 2025 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   2s ⏱️ -1s
233 tests ±0  233 ✅ ±0  0 💤 ±0  0 ❌ ±0 
238 runs  ±0  238 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 43d615e. ± Comparison against base commit 64fbf95.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 21, 2025

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   13s ⏱️ -1s
233 tests ±0  233 ✅ ±0  0 💤 ±0  0 ❌ ±0 
238 runs  ±0  238 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 43d615e. ± Comparison against base commit 64fbf95.

♻️ This comment has been updated with latest results.

…olo-flags-in-remoteconfig

# Conflicts:
#	src/core/config/remote/remote_config_manager.ts
Copy link
Contributor

github-actions bot commented Jan 21, 2025

E2E Test Report

 17 files  126 suites   1h 29m 11s ⏱️
258 tests 258 ✅ 0 💤 0 ❌
269 runs  269 ✅ 0 💤 0 ❌

Results for commit 43d615e.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Jan 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 64fbf951 74.42%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (64fbf95) Report Missing Report Missing Report Missing
Head commit (43d615e) 21868 18309 83.73%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1191) 172 128 74.42%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 73.83721% with 45 lines in your changes missing coverage. Please review.

Project coverage is 82.84%. Comparing base (9d1a8cb) to head (43d615e).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...rc/core/config/remote/common_flags_data_wrapper.ts 71.77% 35 Missing ⚠️
src/core/config/remote/listr_config_tasks.ts 54.54% 5 Missing ⚠️
src/core/config/remote/remote_config_manager.ts 66.66% 4 Missing ⚠️
src/commands/mirror_node.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1191      +/-   ##
==========================================
- Coverage   82.89%   82.84%   -0.05%     
==========================================
  Files          78       79       +1     
  Lines       21763    21868     +105     
  Branches     1383     1899     +516     
==========================================
+ Hits        18040    18117      +77     
+ Misses       3696     3597      -99     
- Partials       27      154     +127     
Files with missing lines Coverage Δ
src/core/config/remote/components_data_wrapper.ts 84.81% <100.00%> (-0.58%) ⬇️
src/core/config/remote/metadata.ts 100.00% <100.00%> (ø)
...c/core/config/remote/remote_config_data_wrapper.ts 93.02% <100.00%> (+1.59%) ⬆️
src/commands/mirror_node.ts 75.61% <50.00%> (ø)
src/core/config/remote/remote_config_manager.ts 76.03% <66.66%> (-0.25%) ⬇️
src/core/config/remote/listr_config_tasks.ts 65.21% <54.54%> (-1.81%) ⬇️
...rc/core/config/remote/common_flags_data_wrapper.ts 71.77% <71.77%> (ø)

... and 35 files with indirect coverage changes

Impacted file tree graph

…es when passed to command, since they are overriden on configManager.update which is called at the beggining of all commands

Signed-off-by: instamenta <[email protected]>
…g the post middleware command execution

Signed-off-by: instamenta <[email protected]>
@instamenta instamenta added PR: Needs Approval A pull request that needs reviews and approvals. and removed PR: Needs Approval A pull request that needs reviews and approvals. labels Jan 22, 2025
@jeromy-cannon jeromy-cannon added the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Jan 22, 2025
…olo-flags-in-remoteconfig

# Conflicts:
#	src/commands/deployment.ts
#	src/core/config/remote/remote_config_manager.ts
#	src/core/config/remote/remote_config_tasks.ts
Signed-off-by: instamenta <[email protected]>
@jeromy-cannon jeromy-cannon removed the PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. label Jan 23, 2025
instamenta and others added 2 commits January 23, 2025 15:52
Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jan Milenkov <[email protected]>
…n-remoteconfig' into 01178-save-reusable-solo-flags-in-remoteconfig
Signed-off-by: instamenta <[email protected]>
@jeromy-cannon jeromy-cannon added the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Jan 23, 2025
@instamenta instamenta removed the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Jan 24, 2025
@jeromy-cannon jeromy-cannon added PR: Needs Approval A pull request that needs reviews and approvals. PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved. and removed PR: Needs Approval A pull request that needs reviews and approvals. labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Merge Conflicts A pull request that has merge conflicts that need to be resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save reusable solo flags in RemoteConfig
2 participants