-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remote-config): save reusable solo flags in remoteconfig #1191
base: main
Are you sure you want to change the base?
Conversation
…r it Signed-off-by: instamenta <[email protected]>
…mote config common flags data wrapper and fix failing tests Signed-off-by: instamenta <[email protected]>
…re type imports because they are impossible to fix in the context of the remote config Signed-off-by: instamenta <[email protected]>
…olo-flags-in-remoteconfig
…olo-flags-in-remoteconfig # Conflicts: # src/core/config/remote/remote_config_manager.ts
E2E Test Report 17 files 126 suites 1h 29m 11s ⏱️ Results for commit 43d615e. ♻️ This comment has been updated with latest results. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
Signed-off-by: Jeromy Cannon <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1191 +/- ##
==========================================
- Coverage 82.89% 82.84% -0.05%
==========================================
Files 78 79 +1
Lines 21763 21868 +105
Branches 1383 1899 +516
==========================================
+ Hits 18040 18117 +77
+ Misses 3696 3597 -99
- Partials 27 154 +127
|
…es when passed to command, since they are overriden on configManager.update which is called at the beggining of all commands Signed-off-by: instamenta <[email protected]>
…g the post middleware command execution Signed-off-by: instamenta <[email protected]>
…olo-flags-in-remoteconfig # Conflicts: # src/commands/deployment.ts # src/core/config/remote/remote_config_manager.ts # src/core/config/remote/remote_config_tasks.ts
Signed-off-by: instamenta <[email protected]>
Co-authored-by: Jeromy Cannon <[email protected]> Signed-off-by: Jan Milenkov <[email protected]>
Signed-off-by: instamenta <[email protected]>
…n-remoteconfig' into 01178-save-reusable-solo-flags-in-remoteconfig
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
test/unit/core/remote_config/remote_config_data_wrapper.test.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Description
adds new class
CommonFlagsDataWrapper
to handle keeping the state of the flags inside the remote config, it's added to the middleware which loads and and it will populate the flags if needed.Related Issues