Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mirror-node): Enhance mirror-node external database feature #1230

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

instamenta
Copy link
Contributor

Description

Deprecated the flag --custom-mirror-node-database-values-path,
instead there is new strategy together with 3 new flags:

  • --use-external-database - boolean flag that signalizes you want to enable the feature
  • --external-database-host - provides the external database host
  • --external-database-owner-username - provides the external database owner's username
  • --external-database-owner-password - provides the external database owner's password

Related Issues

@instamenta instamenta added the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Jan 29, 2025
@instamenta instamenta self-assigned this Jan 29, 2025
@instamenta instamenta requested review from leninmehedy and a team as code owners January 29, 2025 13:46
@instamenta instamenta linked an issue Jan 29, 2025 that may be closed by this pull request
@instamenta instamenta marked this pull request as draft January 29, 2025 13:46
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   1s ⏱️ -1s
235 tests ±0  235 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 06d8f40. ± Comparison against base commit cc8eba4.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 29, 2025

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   2s ⏱️ -1s
235 tests ±0  235 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 06d8f40. ± Comparison against base commit cc8eba4.

♻️ This comment has been updated with latest results.

… added the new flags to igrone prompts

Signed-off-by: instamenta <[email protected]>
…node-external-database-feature

# Conflicts:
#	src/commands/mirror_node.ts
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
@jeromy-cannon jeromy-cannon added PR: Checks Failed A pull request where the checks have failed. and removed PR: Unresolved Comments A pull request where there are comments and they need to be resolved. labels Feb 3, 2025
Signed-off-by: instamenta <[email protected]>
…node-external-database-feature

# Conflicts:
#	src/commands/mirror_node.ts
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
…node-external-database-feature

# Conflicts:
#	src/commands/mirror_node.ts
Signed-off-by: instamenta <[email protected]>
Copy link
Contributor

github-actions bot commented Feb 5, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 27m 45s ⏱️ -1s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 400d7da. ± Comparison against base commit 620e2f4.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 27m 32s ⏱️ +10s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 06d8f40. ± Comparison against base commit cc8eba4.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Feb 5, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.29% (target: -1.00%) 42.41%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (cc8eba4) 22152 18418 83.14%
Head commit (06d8f40) 22323 (+171) 18495 (+77) 82.85% (-0.29%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1230) 191 81 42.41%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 39.79058% with 115 lines in your changes missing coverage. Please review.

Project coverage is 81.87%. Comparing base (cc8eba4) to head (06d8f40).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/mirror_node.ts 27.27% 80 Missing ⚠️
src/commands/flags.ts 61.97% 27 Missing ⚠️
src/core/helpers.ts 20.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
- Coverage   82.16%   81.87%   -0.29%     
==========================================
  Files         106      107       +1     
  Lines       22152    22323     +171     
  Branches     2126     1388     -738     
==========================================
+ Hits        18201    18278      +77     
- Misses       3774     4038     +264     
+ Partials      177        7     -170     
Files with missing lines Coverage Δ
src/core/helpers.ts 79.63% <20.00%> (-1.60%) ⬇️
src/commands/flags.ts 75.84% <61.97%> (-0.60%) ⬇️
src/commands/mirror_node.ts 68.55% <27.27%> (-6.20%) ⬇️

... and 48 files with indirect coverage changes

Impacted file tree graph

@instamenta instamenta marked this pull request as ready for review February 6, 2025 12:01
@instamenta instamenta requested a review from a team as a code owner February 6, 2025 12:01
Taskfile.helper.yml Outdated Show resolved Hide resolved
src/commands/flags.ts Outdated Show resolved Hide resolved
Comment on lines +163 to +164
'db.owner.username': username,
'importer.db.username': username,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to double check Nathan's script, but I think these two are using the provisioner username, the rest are using the mirror username

@jeromy-cannon jeromy-cannon added the PR: Unresolved Comments A pull request where there are comments and they need to be resolved. label Feb 6, 2025
Signed-off-by: instamenta <[email protected]>
@instamenta instamenta requested review from a team as code owners February 6, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Checks Failed A pull request where the checks have failed. PR: Unresolved Comments A pull request where there are comments and they need to be resolved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhance mirror node external database feature
2 participants