-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mirror-node): Enhance mirror-node external database feature #1230
base: main
Are you sure you want to change the base?
feat(mirror-node): Enhance mirror-node external database feature #1230
Conversation
… used, together with a helper for them Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
… added the new flags to igrone prompts Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
…node-external-database-feature # Conflicts: # src/commands/mirror_node.ts
…-node deploy command' Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
…node-external-database-feature # Conflicts: # src/commands/mirror_node.ts
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
…node-external-database-feature # Conflicts: # src/commands/mirror_node.ts
Signed-off-by: instamenta <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1230 +/- ##
==========================================
- Coverage 82.16% 81.87% -0.29%
==========================================
Files 106 107 +1
Lines 22152 22323 +171
Branches 2126 1388 -738
==========================================
+ Hits 18201 18278 +77
- Misses 3774 4038 +264
+ Partials 177 7 -170
|
…node-external-database-feature
Signed-off-by: instamenta <[email protected]>
…node-external-database-feature
…ir removal Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
Signed-off-by: instamenta <[email protected]>
'db.owner.username': username, | ||
'importer.db.username': username, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you might want to double check Nathan's script, but I think these two are using the provisioner username, the rest are using the mirror username
Signed-off-by: instamenta <[email protected]>
…node-external-database-feature
…t on external db wait period Signed-off-by: instamenta <[email protected]>
Description
Deprecated the flag
--custom-mirror-node-database-values-path
,instead there is new strategy together with 3 new flags:
--use-external-database
- boolean flag that signalizes you want to enable the feature--external-database-host
- provides the external database host--external-database-owner-username
- provides the external database owner's username--external-database-owner-password
- provides the external database owner's passwordRelated Issues