Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to using symbols for tokens in tsyringe #1337

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

jeromy-cannon
Copy link
Contributor

Description

This pull request changes the following:

  • switch to using symbols for tokens in tsyringe

Related Issues

@jeromy-cannon jeromy-cannon self-assigned this Feb 10, 2025
Copy link
Contributor

github-actions bot commented Feb 10, 2025

Unit Test Results - Linux

  1 files  ±0   59 suites  ±0   3s ⏱️ -1s
231 tests ±0  231 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit aa4df69. ± Comparison against base commit 6bfdecd.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 10, 2025

Unit Test Results - Windows

  1 files  ±0   59 suites  ±0   4s ⏱️ +2s
231 tests ±0  231 ✅ ±0  0 💤 ±0  0 ❌ ±0 
240 runs  ±0  240 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit aa4df69. ± Comparison against base commit 6bfdecd.

♻️ This comment has been updated with latest results.

@jeromy-cannon jeromy-cannon marked this pull request as ready for review February 10, 2025 00:39
@jeromy-cannon jeromy-cannon requested review from leninmehedy and a team as code owners February 10, 2025 00:39
@jeromy-cannon jeromy-cannon added the PR: Needs Approval A pull request that needs reviews and approvals. label Feb 10, 2025
instamenta
instamenta previously approved these changes Feb 10, 2025
Copy link
Contributor

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 33m 32s ⏱️ + 5m 58s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit efc8417. ± Comparison against base commit fd11990.

Copy link
Contributor

github-actions bot commented Feb 10, 2025

E2E Test Report

 17 files  ±0  126 suites  ±0   1h 29m 21s ⏱️ + 1m 45s
254 tests ±0  254 ✅ ±0  0 💤 ±0  0 ❌ ±0 
265 runs  ±0  265 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit aa4df69. ± Comparison against base commit 6bfdecd.

♻️ This comment has been updated with latest results.

Copy link

codacy-production bot commented Feb 10, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09% (target: -1.00%) 97.81%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6bfdecd) 22995 19282 83.85%
Head commit (aa4df69) 23065 (+70) 19361 (+79) 83.94% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1337) 366 358 97.81%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 97.81421% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (6bfdecd) to head (aa4df69).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/core/dependency_injection/container_init.ts 94.80% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1337      +/-   ##
==========================================
+ Coverage   82.77%   82.87%   +0.09%     
==========================================
  Files         126      127       +1     
  Lines       22995    23065      +70     
  Branches     2261     1704     -557     
==========================================
+ Hits        19035    19114      +79     
- Misses       3771     3859      +88     
+ Partials      189       92      -97     
Files with missing lines Coverage Δ
src/commands/cluster/tasks.ts 83.23% <100.00%> (ø)
src/commands/explorer.ts 70.42% <100.00%> (+0.05%) ⬆️
src/commands/node/tasks.ts 93.81% <100.00%> (ø)
src/core/account_manager.ts 84.61% <100.00%> (+0.01%) ⬆️
src/core/certificate_manager.ts 49.51% <100.00%> (+0.24%) ⬆️
src/core/chart_manager.ts 86.33% <100.00%> (+0.09%) ⬆️
src/core/cluster_checks.ts 66.41% <100.00%> (+0.25%) ⬆️
src/core/config/local_config.ts 64.13% <100.00%> (+0.15%) ⬆️
src/core/config/remote/remote_config_manager.ts 71.17% <100.00%> (+0.08%) ⬆️
src/core/config_manager.ts 94.50% <100.00%> (+0.02%) ⬆️
... and 20 more

... and 20 files with indirect coverage changes

Impacted file tree graph

commit efc8417
Author: Jeromy Cannon <[email protected]>
Date:   Mon Feb 10 00:35:23 2025 +0000

    removed incorrect import

    Signed-off-by: Jeromy Cannon <[email protected]>

commit 0c8a7f2
Author: Jeromy Cannon <[email protected]>
Date:   Mon Feb 10 00:31:01 2025 +0000

    Squashed commit of the following:

    commit 8ee5902
    Author: Jeromy Cannon <[email protected]>
    Date:   Mon Feb 10 00:28:34 2025 +0000

        missed some

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 7ab6be2
    Author: Jeromy Cannon <[email protected]>
    Date:   Mon Feb 10 00:23:36 2025 +0000

        set type

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 1f95b8a
    Author: Jeromy Cannon <[email protected]>
    Date:   Mon Feb 10 00:19:37 2025 +0000

        cleared another round of InjectTokens

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit a41236f
    Author: Jeromy Cannon <[email protected]>
    Date:   Mon Feb 10 00:09:16 2025 +0000

        cleared another round of InjectTokens

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit e707891
    Author: Jeromy Cannon <[email protected]>
    Date:   Sun Feb 9 23:42:13 2025 +0000

        more solologger tokens & index.ts

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit a2ea049
    Author: Jeromy Cannon <[email protected]>
    Date:   Sun Feb 9 23:35:20 2025 +0000

        more solologger tokens

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 533a2c1
    Author: Jeromy Cannon <[email protected]>
    Date:   Sun Feb 9 22:49:45 2025 +0000

        update SoloLogger

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 83a6d4a
    Author: Jeromy Cannon <[email protected]>
    Date:   Sun Feb 9 22:37:34 2025 +0000

        updated container.register() to use tokens

        Signed-off-by: Jeromy Cannon <[email protected]>

    commit 22e1c17
    Author: Jeromy Cannon <[email protected]>
    Date:   Sun Feb 9 22:19:49 2025 +0000

        moved tsyringe classes into dependency_injection folder

        Signed-off-by: Jeromy Cannon <[email protected]>

    Signed-off-by: Jeromy Cannon <[email protected]>

Signed-off-by: Jeromy Cannon <[email protected]>
@jeromy-cannon jeromy-cannon merged commit 8e943b7 into main Feb 10, 2025
41 of 42 checks passed
@jeromy-cannon jeromy-cannon deleted the 01336-tsyringe-tokens branch February 10, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Needs Approval A pull request that needs reviews and approvals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

switch to using symbols for tokens in tsyringe
2 participants