Cleanup and revert some changes

hashicorp-forge · Dec 18, 2023 · 8230a81 · 8230a81
1 parent da25921
commit 8230a81
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 75 deletions.
diff --git a/web/app/components/floating-u-i/content.ts b/web/app/components/floating-u-i/content.ts
@@ -52,6 +52,7 @@ export default class FloatingUIContent extends Component<FloatingUIContentSignat
    */
   protected get inElementTarget() {
     const dialog = document.querySelector("dialog");
+
     if (dialog) {
       return "dialog";
     } else {

diff --git a/web/app/components/new/form.ts b/web/app/components/new/form.ts
@@ -36,10 +36,6 @@ interface NewFormComponentSignature {
 export default class NewFormComponent extends Component<NewFormComponentSignature> {
   protected motion = HermesFormResize;
 
-  protected get headlineIsShown() {
-    return !this.args.isModal;
-  }
-
   protected get taskIsRunningMessageIsShown() {
     return this.args.taskIsRunning && !this.args.isModal;
   }

diff --git a/web/app/components/new/project-form.ts b/web/app/components/new/project-form.ts
@@ -38,20 +38,13 @@ export default class NewProjectFormComponent extends Component<NewProjectFormCom
    * Reverted only if an error occurs.
    */
   @tracked protected projectIsBeingCreated = false;
-  @tracked protected jiraSearchIsShowing = false;
-  @tracked protected jiraSearchQuery = "";
-  @tracked protected jiraIssue: JiraPickerResult | undefined = undefined;
 
-  @tracked protected shownJiraIssues = [];
+  @tracked protected jiraIssue: JiraPickerResult | undefined = undefined;
 
   @tracked protected title: string = "";
   @tracked protected description: string = "";
   @tracked protected titleErrorIsShown = false;
 
-  private validate() {
-    this.titleErrorIsShown = this.title.length === 0;
-  }
-
   /**
    * Whether the Jira integration is enabled.
    * Determines whether the Jira input is rendered.
@@ -89,6 +82,10 @@ export default class NewProjectFormComponent extends Component<NewProjectFormCom
     }
   }
 
+  private validate() {
+    this.titleErrorIsShown = this.title.length === 0;
+  }
+
   /**
    * The action run on title- and description-input keydown.
    * If the key is Enter, a form submission is attempted.

diff --git a/web/app/components/new/project-form/title-and-description.hbs b/web/app/components/new/project-form/title-and-description.hbs
diff --git a/web/app/components/new/project-form/title-and-description.ts b/web/app/components/new/project-form/title-and-description.ts
diff --git a/web/app/components/project/index.hbs b/web/app/components/project/index.hbs
@@ -26,7 +26,10 @@
             class="hds-button hds-button--size-medium hds-button--color-secondary rounded-r-full rounded-l-full border-color-border-strong"
             @hasChevron={{true}}
           >
-            <FlightIcon @name={{get-project-status-icon dd.selected}} />
+            <FlightIcon
+              @name={{get-project-status-icon dd.selected}}
+              class="-mr-1"
+            />
             <span class="status ml-2">
               {{this.statusLabel}}
             </span>

diff --git a/web/app/components/project/index.ts b/web/app/components/project/index.ts
@@ -87,14 +87,6 @@ export default class ProjectIndexComponent extends Component<ProjectIndexCompone
     return this.statuses[this.status].label;
   }
 
-  /**
-   * The icon for the status dropdown.
-   * Represents the current status of the project.
-   */
-  protected get statusIcon() {
-    return this.statuses[this.status].icon;
-  }
-
   /**
    * The URL of the project. Used by the CopyURLButton.
    */