Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allocrunner: handle alloc updates from job stop. #18

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

jrasell
Copy link
Contributor

@jrasell jrasell commented Mar 26, 2024

This change adds minor functionality to handle job stops which are handled within the alloc-runner by the update function. When an allocation update is pulled from the servers, the simulated runner can now handle transitions to stop by correctly modifying alloc state parameters.

This change adds minor functionality to handle job stops which are
handled within the alloc-runner by the update function. When an
allocation update is pulled from the servers, the simulated runner
can now handle transitions to stop by correctly modifying alloc
state parameters.
@jrasell jrasell self-assigned this Mar 26, 2024
Copy link

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah funny, didn't realize that the simulated nodes don't actually run anything. This explains why none of the mock driver configs I tried actually worked 😅

I wonder if we'll need to make it work for some tests, but we can do that when the need arises.

@jrasell jrasell merged commit b1f5c1c into main Mar 27, 2024
1 check passed
@jrasell jrasell deleted the f-jrasell-allocrunner-stop branch March 27, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants