Upgrade electron-forge to 7.5.0 #2526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… its not need anymore
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…upport for non-numeric appVersion in windows
ZedLi
reviewed
Oct 29, 2024
| major = major.replace('v', ''); | ||
| } | ||
|
|
||
| return major.concat('.', minor, '.', parseInt(patch)); |
There was a problem hiding this comment.
Do we parseInt(patch) to basically remove any text that may have been attached to it? e.g. 1-beta in 3.2.1-beta? If so, perhaps we could add a comment to explain that?
Could this also have just used a template string?
Suggested change
| return major.concat('.', minor, '.', parseInt(patch)); | |
| return `${major}.${minor}.${parseInt(patch)}` |
There was a problem hiding this comment.
Yes.
- The
parseIntforpatchwas add for that exact reason. Good catch, added a comment. - I also move the comment to explain
returnSemVerFromReleaseVersion.
cameronperera
approved these changes
Nov 6, 2024
ZedLi
approved these changes
Nov 6, 2024
DhariniJeeva
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
electron-app.The reason behind this changes is electron-forge/packer changed the way it validates semver for windows, therefore, the pattern we used before turns out invalid and returns an error when building the desktop client. More info about the issue within this GH ticket. Code that validates the semVer, within packager.
Due to this change, don't support non-numeric version, we add the function
returnSemVerFromReleaseVersionto clean up the provided releaseVersion and bein compliance.Delete lodash patch for electron-app its not need anymore. The new version of electron-forge resolves lodash
4.17.21, as per snyk scan, does not have security vulnerabilities.How to Test
returnSemVerFromReleaseVersionwith next string:1.2.3-beta.test.node.pty=1.2.3;0.2.3-beta.electron.forge=0.2.3;v2.0.3=2.0.3;v0.10.3=0.10.3;