refactor: 💡 remove rose::notification in favor of hds #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…omponent' of https://github.com/hashicorp/boundary-ui into ICU-15634-use-hds-alert-in-place-of-rose-notification-component
lisbet-alvarez
commented
Nov 12, 2024
| @@ -0,0 +1,21 @@ | |||
| /** | |||
There was a problem hiding this comment.
this is a simple helper made to map the flash message type to hds toast color. Let me know if y'all have a better suggestion.
lisbet-alvarez
commented
Nov 12, 2024
| cursor: pointer; | ||
| float: right; | ||
| } | ||
| width: 360px; |
There was a problem hiding this comment.
hds toast size is 360px.
Also this file was using only pixels. Should this be refactored to use rem instead ?
lisbet-alvarez
commented
Nov 12, 2024
| @@ -128,21 +128,18 @@ | |||
| </Rose::Layout::Global> | |||
|
|
|||
| {{#if this.flashMessages.queue}} | |||
| <div class='ember-notify-cn ember-notify-default'> | |||
There was a problem hiding this comment.
some of the class names in these divs were not being used so i removed them. Let me know if they had a purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15634
Description
Replace the rose notification component used by flashMessages service with Hds::Toast.
Hds::Toast guidelines specify placement of toast to be bottom right.
Admin UI:
success toast
Screen.Recording.2024-11-12.at.3.36.53.PM.mov
error toast
Screen.Recording.2024-11-12.at.3.37.24.PM.mov
authentication-complete & authentication-error hds alerts
Screen.Recording.2024-11-12.at.3.38.04.PM.mov
Desktop UI:
toast
Screen.Recording.2024-11-12.at.3.43.14.PM.mov
Screenshots (if appropriate)
How to Test
Checklist