refactor: 💡 move WorkerFilter component to more generic folder #2558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ZedLi
approved these changes
Nov 12, 2024
DhariniJeeva
approved these changes
Nov 12, 2024
cameronperera
deleted the
ICU-15742-move-existing-worker-filter-component
branch
| @@ -19,7 +19,7 @@ module('Integration | Component | form/target/worker-filter', function (hooks) { | |||
| this.cancel = () => {}; | |||
| this.model = { egress_worker_filter: 'egress filter' }; | |||
| await render( | |||
| hbs`<Form::Target::WorkerFilter @name='egress_worker_filter' @model={{this.model}} @onInput={{this.onInput}} @submit={{this.submit}} @cancel={{this.cancel}} />`, | |||
| hbs`<WorkerFilter @name='egress_worker_filter' @model={{this.model}} @onInput={{this.onInput}} @submit={{this.submit}} @cancel={{this.cancel}} />`, | |||
| ); | |||
There was a problem hiding this comment.
is OnInput used? I don't see it being passed to the component
@name='ingress_worker_filter'
@model={{@model}}
@submit={{fn this.targets.saveWorkerFilter @model}}
@cancel={{fn this.targets.cancelWorkerFilter @model}}
/>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15742
Description
refactor: 💡 move WorkerFilter component to more generic folder
This is in preparation for Worker Filter Improvement work. This component will be used for multiple resource types so we wanted to move it out to a more generic component level.
Screenshots (if appropriate)
Screen.Recording.2024-11-12.at.11.39.10.AM.mov
How to Test
Checklist