Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icu 15743 tag workflow #2565

Merged
merged 5 commits into from
Nov 14, 2024
Merged

Icu 15743 tag workflow #2565

merged 5 commits into from
Nov 14, 2024
+128 −2

Conversation

cameronperera
Copy link
Collaborator

Description

This PR adds the workflow for creating a tag specific worker filter

Screenshots (if appropriate)

Screen.Recording.2024-11-13.at.3.05.33.PM.mov

How to Test

  1. Go to the workers tab on a Target, toggle the "show generator" toggle
  2. Enter in the key and value
  3. Should be able to copy the formatted result

Checklist

  • I have added before and after screenshots for UI changes
  • I have added JSON response output for API changes
  • I have added steps to reproduce and test for bug fixes in the description
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@cameronperera cameronperera self-assigned this Nov 13, 2024
@cameronperera cameronperera requested a review from a team as a code owner November 13, 2024 21:12
@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
boundary-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:17pm
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:17pm

@cameronperera @lisbet-alvarez
Apply suggestions from code review
8af16ba 
minor translation change

Co-authored-by: Lisbet Alvarez <[email protected]>
lisbet-alvarez
lisbet-alvarez approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@cameronperera cameronperera merged commit 5f56235 into llb/worker-filter-improvements Nov 14, 2024
10 checks passed
@cameronperera cameronperera deleted the ICU-15743-tag-workflow branch November 14, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisbet-alvarez lisbet-alvarez lisbet-alvarez approved these changes

Assignees

@cameronperera cameronperera

Labels
addons admin ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cameronperera @lisbet-alvarez