Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto/api: improve auth method service API docs #4616

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

johanbrandhorst
Copy link
Collaborator

@johanbrandhorst johanbrandhorst commented Apr 9, 2024

Updates the auth method API documentation along the patterns established in #4555.

Reviewers: copy the contents of controller.swagger.json and upload to https://developer.hashicorp.services/open-api-docs-preview to review the look of the changes. Feel free to also try uploading it to https://editor-next.swagger.io/ to compare against a more capable OpenAPIv2 renderer. Note that the developer preview OpenAPI docs page suffers a few issues. If you see anything that isn't already mentioned in the feedback doc, let me know.

@johanbrandhorst johanbrandhorst force-pushed the jbrandhorst-further-api-improvements branch from e11fc78 to 249b5de Compare April 9, 2024 05:27
@johanbrandhorst johanbrandhorst added this to the 0.16.x milestone Apr 9, 2024
@johanbrandhorst johanbrandhorst marked this pull request as ready for review April 9, 2024 05:28
Copy link
Contributor

@Dan-Heath Dan-Heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thank you!

@johanbrandhorst johanbrandhorst merged commit 31f4b73 into main Apr 9, 2024
61 of 63 checks passed
@johanbrandhorst johanbrandhorst deleted the jbrandhorst-further-api-improvements branch April 9, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants