feat(plugin): add GCP plugin #5229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add GCP as a supported plugin for dynamic host catalogs
louisruch
reviewed
Nov 7, 2024
There was a problem hiding this comment.
Seems straight forward enough, would love to get some extra of those enos tests passing.
We might wanna sync with @moduli to see if we can get him or other people allocated to getting the enos tests that have been failing for a while green. I know in oss it has been that CLISearch test, but enterprise has a bunch of failing ones.
louisruch
approved these changes
Nov 8, 2024
|
@louisruch Thanks for the ping. I'll be working to try to triage those errors and will ping for assistance as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GCP as a supported plugin for dynamic host catalog