NET-9173: tcp acceptance tests #3988
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiniOak
added
backport/1.1.x
NiniOak
commented
May 11, 2024
| fmt.Printf("%s%s\n", command.Command, command.Args) | ||
| fmt.Println(string(output)) | ||
| } | ||
| } |
There was a problem hiding this comment.
Left for testing, will remove
NiniOak
commented
May 11, 2024
| // { | ||
| // "default installation", | ||
| // false, | ||
| // }, |
NiniOak
force-pushed
the
NET-9173_tcp_acceptance_tests
branch
from
5c27350
to
9f36a1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
❗ ADDED TEST IS FAILING ❗
httpexternal services accessible over a peering connection here;This PR adds acceptance test coverage for tcp external services in the same setup. External service was updated to a TCP / HTTP port enabled service.
How I've tested this PR
CI should pass
How I expect reviewers to test this PR
CI should pass
Checklist