Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Fix ArgoCD hooks annotation location into release/1.4.x #4186

Open
wants to merge 3 commits into
base: release/1.4.x
Choose a base branch
from

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #3989 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR

ArgoCD hooks to be set to Job annotations and not at Job template spec level -> https://argo-cd.readthedocs.io/en/stable/user-guide/resource_hooks/#usage

If set at current Job template spec level when Job is finished ArgoCD detects back again diff entering into a loop, if ArgoCD AutoSync is enabled this will be a loop of init jobs running forever.

fix: #3831

How I've tested this PR

  • Ran helm bats tests successfully.

How I expect reviewers to test this PR

  • Deploy this chart using ArgoCD Application. Without the fix after the sync it will enter in a diff sync loop.

Checklist


Overview of commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants