New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add k8s topology zone info for nodePort service #4301

Open

kolorful wants to merge 1 commit into hashicorp:main from kolorful:main

Contributor

kolorful commented Sep 3, 2024 •

edited

Loading

Changes proposed in this PR

add k8s topology zone info for nodePort service (This feature implemented in feature: [syncCatalog] Add available Region and Zone Kubernetes Topology Metadata when Syncing Kubernetes Services #3522 was missed when combining into Catalog: Use EndpointSlice and propagate Kubernetes Topology information to synced consul service #3693)

How I've tested this PR

Unit test
Running locally compiled version on a production Kubernetes cluster and verified it worked (see attached screenshot)

How I expect reviewers to test this PR

Same as how I tested

Checklist

Tests added
CHANGELOG entry added

kolorful force-pushed the main branch from d91930f to 04ebc1e Compare

September 3, 2024 16:30


          feat: add k8s topology zone info for nodePort service

dc24ff2

kolorful force-pushed the main branch from 04ebc1e to dc24ff2 Compare

September 3, 2024 16:39

kolorful marked this pull request as ready for review

September 3, 2024 17:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet